Repository navigation
Remove ineffective arbitrary-want setting - #85
behinddwalls wants to merge 2 commits into
Conversation
## Summary ### Why? Partial-clone lazy fetches require direct object wants, while the configuration claimed they could be disabled even though both upload-pack engines always accepted them. ### What? Remove the inert `git.allow_any_sha1_in_want` option and update tests and integrity documentation to describe arbitrary object wants as part of partial-clone support. ## Test Plan⚠️ Rust tests were not run because `cargo` is unavailable in this environment; `git diff --check` passes. ## Issue Closes tobi#77
|
CI is waiting on approval for this stack, so I ran the whole thing locally on top of main. Tests, e2e and the sims all pass. Clippy fails on one lint that comes from #86 ( #85, #87, #89, #91 and #92 look good to me and could each go in on their own if rebased on main. #87 needs that rebase anyway since its check sits in the middle of #86's lines. For this one it might be worth a line in the docs saying read access already lets anyone fetch any stored object by id, unreachable ones included, so nobody reads the removal as dropping a protection. |
Clarify that repository read access already permits fetching stored objects by ID, including unreachable objects, so removing the ineffective configuration switch does not widen authorization.
|
Added the clarification in [addressed by agent] |
|
Reworked the reviewed branches as independent changes on [addressed by agent] |
Summary
Why?
Partial-clone lazy fetches require direct object wants, while the configuration claimed they could be disabled even though both upload-pack engines always accepted them.
What?
Remove the inert
git.allow_any_sha1_in_wantoption and update tests and integrity documentation to describe arbitrary object wants as part of partial-clone support.Test Plan
✅
cargo test -p walgit-server --test e2e partial_clone_tree_zero_and_depth_with_filter -- --exact✅
cargo fmt --all -- --check✅
git diff --checkIssue
Closes #77