Repository navigation
Conversation
telenko
reviewed
Oct 30, 2022
telenko
left a comment
telenko
left a comment
Owner
There was a problem hiding this comment.
Hey, sorry for late code review, I was too busy with other things. Let me know if you have some questions/proposals/ideas :)
| apply(compiler) { | ||
| const { getRemoteUri, ...options } = this.options; | ||
| const { | ||
| customRpcLoadTemplate, |
Owner
There was a problem hiding this comment.
since you're adding new options - please document them.
| } | ||
| //TODO https support | ||
| let request = (url.startsWith('https') ? require('https') : require('http')).get(url, function(resp) { | ||
| if (resp.statusCode === 200) { |
Owner
There was a problem hiding this comment.
This template should reuse rpcLoad template to avoid duplicates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, considering the issue that @ScriptedAlchemy raised, I propose to pass optional custom templates.
I also propose to isolate rpc functions and make them more straightforward with the minimum of logic (such as the arguments parsing).