Skip to content

promiseBaseURI is not defined #14

Open

Description

@marciotc

the line 205 in ReadFileChunkLoadingRuntimeModule.js should be changed to:
`rpcLoad( promiseBaseURI ? await promiseBaseURI : baseURI }, ${

Activity

  1. noreiller commented on Jul 26, 2022

    @noreiller
    Contributor

    Hello @marciotc, the promise is resolved at runtime and not at build time so it must be inlined with the template string.

    But you are also right, I forgot to replace the HMR part with the new option like in the loading part. 🤦

    If you open a PR, I suppose @telenko would accept the fix.

  2. marciotc commented on Aug 2, 2022

    @marciotc
    Author

    Yes. That's why the error occurs. It's missing escapes.
    This is a code generator, but it's looking for definitions in the building scope, not runtime.

  3. noreiller commented on Aug 11, 2022

    @noreiller
    Contributor

    @marciotc @telenko I fixed this in my PR #16

  4. woss commented on Dec 8, 2023

    @woss

    what is the point and purpose of promiseBaseURI variable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions