Skip to content

chore: use ldk-node rc.63 - #679

Merged
piotr-iohk merged 1 commit into
masterfrom
chore/ldk-node-rc.63
Aug 21, 2026
Merged

chore: use ldk-node rc.63#679
piotr-iohk merged 1 commit into
masterfrom
chore/ldk-node-rc.63

Conversation

@ovitrif

@ovitrif ovitrif commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR pins ldk-node from 0.7.0-rc.57 to 0.7.0-rc.63 so iOS master uses the production Lightning stack needed for 2.4.1.

  • Picks up the Electrum runtime / peer-persistence crash fixes already on Android rc.62.
  • Drops the 0.2.2-accept-stale-monitors rust-lightning fork (BITKIT-SEC-004). Stale monitor mismatches fail closed with DangerousValue.
  • Pin only. #664 already removed setAcceptStaleChannelMonitors; ElectrumSyncConfig already has the extra fields, so no app code change.

Release: https://github.com/synonymdev/ldk-node/releases/tag/v0.7.0-rc.63

Intended for cherry-pick onto release-2.4.1.

Linked Issues/Tasks

Screenshot / Video

N/A — dependency pin only.

QA Notes

Manual Tests

  • regression: Launch an existing wallet with channels and send to Android #1175

Automated Checks

  • Resolved SPM to ldk-node 0.7.0-rc.63 (c9a41458).
  • Simulator arm64 Debug build succeeded against the new pin. No UDL call-site fallout.
  • CI: standard build and test checks run by the PR bot.

@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the exact ldk-node Swift package pin from 0.7.0-rc.57 to 0.7.0-rc.63, including the matching resolved revision.

  • Keeps the Xcode package requirement and Package.resolved entry synchronized.
  • Adopts the dependency release that restores strict stale-channel-monitor validation and includes Electrum and peer-persistence fixes.

Confidence Score: 5/5

The dependency-only update appears safe to merge, with the project requirement and resolved package revision consistently advanced.

No concrete build, runtime, security, or package-resolution failure is established by the changed files, and the existing Lightning startup path retains fail-closed stale-monitor handling.

Important Files Changed

Filename Overview
Bitkit.xcodeproj/project.pbxproj Updates the exact ldk-node package requirement to 0.7.0-rc.63; no actionable inconsistency was found.
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved Resolves ldk-node 0.7.0-rc.63 to revision c9a41458a646324c6c8728b4de8329ad4d52ac8d, consistent with the project requirement.

Reviews (1): Last reviewed commit: "chore: use ldk-node rc.63" | Re-trigger Greptile

@ovitrif
ovitrif requested a review from piotr-iohk August 21, 2026 13:46
@ovitrif
ovitrif requested a review from jvsena42 August 21, 2026 14:08
@ovitrif ovitrif added this to the 2.5.0 milestone Aug 21, 2026
@piotr-iohk
piotr-iohk enabled auto-merge August 21, 2026 14:25
@ovitrif ovitrif self-assigned this Aug 21, 2026
@piotr-iohk
piotr-iohk merged commit 32484a7 into master Aug 21, 2026
12 checks passed
@piotr-iohk
piotr-iohk deleted the chore/ldk-node-rc.63 branch August 21, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants