Skip to content

chore: use ldk-node rc.63 - #1175

Merged
ovitrif merged 1 commit into
masterfrom
chore/ldk-node-rc.63
Aug 21, 2026
Merged

chore: use ldk-node rc.63#1175
ovitrif merged 1 commit into
masterfrom
chore/ldk-node-rc.63

Conversation

@ovitrif

@ovitrif ovitrif commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR pins ldk-node-android from 0.7.0-rc.62 to 0.7.0-rc.63 so Android master uses the same production Lightning stack as iOS for 2.4.1.

  • Drops the 0.2.2-accept-stale-monitors rust-lightning fork (BITKIT-SEC-004). Stale monitor mismatches fail closed with DangerousValue.
  • Pin only. #1155 already removed setAcceptStaleChannelMonitors; ElectrumSyncConfig already has the extra fields, so no app code change.

Release: https://github.com/synonymdev/ldk-node/releases/tag/v0.7.0-rc.63

Intended for cherry-pick onto release-2.4.1.

Companion: synonymdev/bitkit-ios#679

Preview

N/A — dependency pin only.

QA Notes

Manual Tests

  • regression: Launch an existing wallet with channels and send to iOS #679

Automated Checks

  • just compile (compileDevDebugKotlin) succeeded against com.synonym:ldk-node-android:0.7.0-rc.63.
  • No UDL call-site fallout.
  • CI: standard compile, unit test, and detekt checks run by the PR bot.

@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown

Greptile Summary

Pins com.synonym:ldk-node-android from 0.7.0-rc.62 to 0.7.0-rc.63, aligning Android with the intended production Lightning stack.

  • Preserves fail-closed startup when channel-monitor state is stale.
  • Makes no application call-site or build-configuration changes.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable defects identified in the dependency pin.

The existing Lightning integration retains fail-closed stale-monitor handling, and the available evidence does not show an incompatible API, artifact, or runtime behavior in rc.63.

Important Files Changed

Filename Overview
gradle/libs.versions.toml Updates only the pinned LDK-node Android release candidate; no concrete compatibility or security regression was identified.

Reviews (1): Last reviewed commit: "chore: use ldk-node rc.63" | Re-trigger Greptile

@ovitrif
ovitrif requested a review from piotr-iohk August 21, 2026 13:49
@ovitrif ovitrif modified the milestones: 2.6.0, 2.5.0 Aug 21, 2026
@ovitrif
ovitrif merged commit 6615032 into master Aug 21, 2026
19 checks passed
@ovitrif
ovitrif deleted the chore/ldk-node-rc.63 branch August 21, 2026 14:25
@ovitrif ovitrif self-assigned this Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants