Repository navigation
fix(export): exported click at the level the app plays it - #837
Merged
Merged
Conversation
… app plays it
The click is rendered mono. Live, Web Audio up-mixes it into the stereo
master as L = R = M. In exports, amix left the conversion to
libswresample's default mono-to-stereo matrix, which puts it 3.01 dB
lower on each channel. Every export now converts the click with an
explicit pan=stereo|c0=c0|c1=c0 (CLICK_TO_STEREO): the mix and region
export, the count-in, the stems zip click file, the MP4 export and take
renders. The zip still sums to the mix. The click sound and its timing
are unchanged.
A cached mix with a click misses the cache now (":u" in the click part
of the key), so an upgrade never serves the old level.
Closes #833
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #833
What changed
pan=stereo|c0=c0|c1=c0(CLICK_TO_STEREO), so each channel carries the click at its volume, as the app plays it (Web Audio up-mixes it as L = R = M). Before, amix left the conversion to libswresample's default matrix: -3.01 dB per channel.:uin the click part of the key), so nobody is served the old level after upgrading. Mixes without a click keep their keys.Render paths touched
app/pipeline/click_render.py:63CLICK_TO_STEREOapp/api/stems.py:1956get_mixdown: mix export (all formats), region export, count-inapp/api/stems.py:2217get_video_mixdown (MP4)app/api/stems.py:2385_render_click_stem(stems zip click file), docstring updatedapp/api/takes.py:1731take renders (Streamer Mode video)app/api/stems.py:262mixdown cache keyWhat did not change
tests/fixtures/click_sounds.jsonall pass untouched.click_levels.json(accent levels, not dB) untouched.Levels (Classic, volume 0.6)
Risks
Tests
UPMIX = 1/sqrt(2)removed fromtests/test_click_sounds.py(zip alignment, chosen-sound mix, zip-sums-to-mix tests now expect unity).Release note: Exported clicks are now 3 dB louder than in 0.20, so they match what you hear in the app. If you set the click level by ear against an export, you may want to turn the click volume down a little.