Skip to content

Guide shows where to point, explains each song fact, and works with no song open - #762

Merged
thcp merged 1 commit into
next-releasefrom
feat/guide-glow
Oct 4, 2026
Merged

thcp merged 1 commit into
next-releasefrom
feat/guide-glow

Conversation

@thcp

@thcp thcp commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator

Three gaps in help mode, found by using it.

What changes

  • A glow when Guide turns on. Every control Guide can explain glows gold for about a second and a half, then fades, so a new user sees where help exists and the screen stays calm afterwards. Large areas such as the waveforms are left out.
  • Each song fact explains itself. Key (and what its small percentage means), BPM, LUFS, duration, dynamic range and tempo stability each have their own box, and every presence card names its instrument: "How loud the Drums part is next to the loudest instrument in the song". The wording matches how the numbers are computed (runner.py presence, analyze.py dynamic range and stability).
  • It works with no song open. The studio turns Export Mix, the song details button and the analysis cards off for the pointer while it is empty, so help mode never heard it over them. In help mode they receive the pointer again; Guide still takes every click, so nothing is pressed by accident.

All new texts are in the ten languages.

Testing

  • tests/e2e/help-mode.spec.mjs: 3 new tests (the glow appears and clears, each card explains itself, an empty studio still explains Export Mix, song details, Key and Global Vocals). 9 pass.
  • Full Playwright suite on next-release plus this and A We Recommend card can link to only one place, and Adrianna Claro is missing #761: 464 passed. One unrelated lyrics test flaked once and passed 24 of 24 on rerun.
  • Automated test run with real separation on an isolated server: 71 of 71 assertions, including these three checks.

Closes #760

…works with no song open

Three gaps in help mode, found by using it:

- Turning Guide on gave no hint of where to point. Every control it can
  explain now glows once, for about a second and a half, and fades, so the
  screen stays calm afterwards. Large areas such as the waveforms are left
  out of the glow.
- The row of song facts was explained as one block. Each card now explains
  itself: key and how sure its guess is, BPM, LUFS, duration, dynamic range,
  tempo stability, and every presence card, naming its instrument.
- With no song open, the studio switches Export Mix, the song details
  button and the analysis cards off for the pointer, so help mode never
  heard it over them. In help mode they receive the pointer again; Guide
  still takes every click, so nothing is pressed by accident.

Closes #760
@thcp
thcp merged commit 6cdc40e into next-release Oct 4, 2026
thcp added a commit that referenced this pull request Oct 4, 2026
…o song open (#762)

feat(help): Guide shows where to point, explains each song fact, and works with no song open

Three gaps in help mode, found by using it:

- Turning Guide on gave no hint of where to point. Every control it can
  explain now glows once, for about a second and a half, and fades, so the
  screen stays calm afterwards. Large areas such as the waveforms are left
  out of the glow.
- The row of song facts was explained as one block. Each card now explains
  itself: key and how sure its guess is, BPM, LUFS, duration, dynamic range,
  tempo stability, and every presence card, naming its instrument.
- With no song open, the studio switches Export Mix, the song details
  button and the analysis cards off for the pointer, so help mode never
  heard it over them. In help mode they receive the pointer again; Guide
  still takes every click, so nothing is pressed by accident.

Closes #760
@thcp
thcp deleted the feat/guide-glow branch October 5, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant