Skip to content

The click track button always says ON, including when the click is off #681

Closed

Description

@thcp

The click track's on/off button carries a fixed label, "ON" (the click.on key, which is "EIN", "ACTIVÉ", "LIGADO" and so on in the other languages). It never changes. With the click off, the button still reads ON, and only the loss of its gold highlight says otherwise.

That is the same kind of mixed signal #655 is about: a control inside the click track area claiming a state it is not in. It turned up while checking the fix for #655 in screenshots, and has been there since before it.

Why not just make it say OFF

It could toggle between ON and OFF, but then the button carries its state twice, in the word and in the highlight, and the word is the less reliable of the two: on a label, "ON" reads equally as a state and as a command to switch on. The highlight is already unambiguous, and it is how the other toggles in that row show their state.

The #655 reporter also suggested showing the click as a metronome icon alone, the way Moises does. That fits here, and it gives back width in a row that already folds its options away when the window is narrow.

Constraints for whoever fixes it

  • The button keeps its accessible name and tooltip, "Click track (K)", so dropping the visible word costs a screen reader nothing.
  • The Grid button shares the same class and keeps its text, so the change has to be specific to the on/off button.
  • The button should match the square icon button beside it (volume), not shrink into a narrower pill.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions