Fail .image.json build on pipeline errors - #992
Open
leighmcculloch wants to merge 2 commits into
Open
leighmcculloch wants to merge 2 commits into
leighmcculloch wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
leighmcculloch
requested review from
mootz12
and
a balanced review from Copilot
September 30, 2026 15:14
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change correctly propagates pipeline failures and removes partial output.
Review effort: Balanced
Findings: None
What changed in this PR
Ensures .image.json generation fails safely when any pipeline stage errors.
Changes:
- Enables Bash
pipefailfor the recipe. - Deletes incomplete targets after recipe failures.
| File | Description |
|---|---|
Makefile |
Adds pipeline error propagation and cleanup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the
.image.jsonrecipe fail, and delete its output, when any stage of the pipeline fails.Why
A failure in
images-resolve-inheritswas masked by the pipe, so the build could succeed with a truncated.image.json(review comment)