Fix image inherits in Makefile - #989
Open
leighmcculloch wants to merge 2 commits into
Open
leighmcculloch wants to merge 2 commits into
leighmcculloch wants to merge 2 commits into
Conversation
leighmcculloch
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Fix tag-sensitive metadata regeneration and propagate inheritance resolver failures.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates the Makefile to resolve inherited image configuration before selecting TAG, matching CI behavior.
Changes:
- Adds inheritance resolution to local image generation.
- Applies extras after selecting the requested image.
| File | Description |
|---|---|
| Makefile | Resolves inherited image definitions before extracting build configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
leighmcculloch
enabled auto-merge (squash)
September 29, 2026 04:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolve image inherits before the Makefile selects the image for
TAG, as CI already does.Why
Local builds never resolved
inherit, so an inheriting image got only its own deps and config, or an empty.image.jsonif it had no deps of its own. When inherits functionality was added we added it to CI, but not to the Makefile for local development.