Repository navigation
Docs: fix driver-catalog count and host-api header - #49
Merged
Merged
Conversation
driver-catalog.md claimed 17 drivers but there are 18 .lua files — the missing solaredge_pv.lua (PV-only SolarEdge variant) is now listed and the count/read-only tally is corrected. host-api.md header said "Legacy WASM ABI reference" but the document covers both Lua and WASM functions. Updated header and intro to reflect both runtimes and cross-reference the authoritative Lua source. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7a2f19142
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+3
to
+4
| > Complete reference for the `host` capability interface exposed to both | ||
| > **Lua** and **WASM** driver runtimes. For a tutorial-style introduction |
There was a problem hiding this comment.
This header now states the page is a complete reference for both Lua and WASM runtimes, but the body documents Lua-only helpers (for example host.decode_u32_le/host.json_decode) that are not WASM host imports; the WASM import surface in go/internal/drivers/abi.go is a different, lower-level ABI (host.emit_telemetry, host.mqtt_poll_messages, etc.). As written, WASM driver authors can follow this page and implement calls that do not exist in the WASM namespace, causing driver integration failures and avoidable debugging churn.
Useful? React with 👍 / 👎.
Contributor
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
frahlg
added a commit
that referenced
this pull request
Sep 27, 2026
…overs (#1456) * refactor(state,mpc,api): remove dead storage, planner and backup leftovers - #49 Keep on a driver draft now takes the driver update lock and removes the record before the saved original, so an expiry already in flight finishes first and Keep answers 409 instead of "kept" for a reverted draft. - #20 History maintenance runs only the plain SQLite stages. Remove the Parquet archive pipeline (rolloff, aggregate/sample archive, legacy compaction, cold/diagnostic Parquet pruning, Store.Prune) and the unused retentionDays closure of rolloffLoop; keep the Parquet readers. - #40 Drop the hot-history alias (s.hot, hotPath, hotWriteMu), dead hot-only branches and readers, forceRotate, heldBytes, RotateHistory and the test-only historyWriter.maintainHistory. - #41 Remove the always-empty ImportedHistoryFiles filter, the unused coldDir parameter of legacyHistoryIdle and the test-only backup.Restore; round-trip tests now use RestoreContents. - #29 Remove the recourse/multistage challenger, unix and auto transports, transport Health and the stateful shadow evaluator. The worker request keeps the same solver settings as constants; the Energyplan process transport and Core DP shadow are unchanged. - #47 Remove the always-zero PV nameplate and load caps (Service fields, Plan.pv_nameplate_w/load_max_w, forecast ACLimitW/ClampForecasts and their web chart caps), the load rain-check and test-only wrappers. A single sanitiser still maps NaN or negative load to 0 W. - #48 Handshake errors now say the bundled Energyplan worker does not match Core and to run `ftw update` or reinstall. Drop PYTHONPATH and fix stale Update Center, CVXPY, Python shadow and scenario comments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MuerPFZFG88kgu8sWVHeq7 * test(mpc): the native contract test no longer expects a scenario model The shared PV scenarios in buildRequest were reachable only by calling ExternalOptimizer directly with a risk margin; production runs through EnergyplanOptimizer, which applies the margin to the slots and zeroes it before the request. Removing that dead block left the native contract test asking for three scenarios. It now checks that a margin never builds a scenario model. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MuerPFZFG88kgu8sWVHeq7 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
solaredge_pv.lua(PV-only SolarEdge variant) row to the table with correct metadata from the driver'sDRIVERblock.go/internal/drivers/lua.go).Test plan
cd go && go test ./...— all tests pass (docs-only changes)ls drivers/*.lua | wc -l= 18🤖 Generated with Claude Code