fix(npm) :: install dependencies only once at root level - #1372
Draft
81reap wants to merge 7 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
package-lock.json, so a contributor installs npm dependencies twice and CI caches only one of the two lockfiles.test-results/andplaywright-report/behind, neither of them ignored.Description
tests/end-to-endas a workspace of the root package, and delete its lockfile.npm cifrom the root in a job that otherwise defaults totests/end-to-end.cd tests/end-to-endin CONTRIBUTING, since that is now where they live.test-results/andplaywright-report/at the root.Testing
tests/end-to-end/node_modulesdeleted,npm installfrom the root is enough fornpx playwright testto run: the suite passes its 41 tests with no second install.npm testchecks 41 files, reports nothing, and passes the 15 unit tests.no console errors on card pagefails for the reason described in fix(biome.js) :: fix remaining lint issues #1366, on this branch and on the unmodified base alike.GitHub cannot base a pull request on a branch that lives in a fork, so all eight target
mainand each one carries the commits of those above it. Review and merge them in order: