fix(biome.js) :: fix remaining lint issues - #1366
Open
81reap wants to merge 1 commit into
Open
Conversation
This was referenced Aug 8, 2026
81reap
marked this pull request as draft
August 8, 2026 23:17
81reap
marked this pull request as ready for review
August 8, 2026 23:19
Author
Author
|
I did also run integration tests. All but one of them passed on my dev machine. The one that fails seems to be a cert issue unrelated to my changes. I will defer to the automated CI runs to confirm. @lovasoa would you be able to start the workflow for me? $ npx playwright test
Running 22 tests using 8 workers
[chromium] › official-site.spec.ts:21:5 › chart
Skipping host requirements validation logic because `PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS` env variable is set.
[chromium] › official-site.spec.ts:233:5 › form example
Skipping host requirements validation logic because `PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS` env variable is set.
[chromium] › official-site.spec.ts:264:5 › Authentication example
Skipping host requirements validation logic because `PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS` env variable is set.
[chromium] › official-site.spec.ts:44:5 › toast notifications initialize, stack, dismiss, and render safely
Skipping host requirements validation logic because `PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS` env variable is set.
[chromium] › official-site.spec.ts:38:5 › map
Skipping host requirements validation logic because `PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS` env variable is set.
[chromium] › official-site.spec.ts:27:5 › chart supports hiding legend
Skipping host requirements validation logic because `PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS` env variable is set.
[chromium] › official-site.spec.ts:5:5 › Open documentation
Skipping host requirements validation logic because `PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS` env variable is set.
[chromium] › official-site.spec.ts:247:5 › File upload
Skipping host requirements validation logic because `PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS` env variable is set.
1) [chromium] › official-site.spec.ts:356:5 › no console errors on card page ─────────────────────
Error: expect(received).toHaveLength(expected)
Expected length: 0
Received length: 2
Received array: ["Failed to load resource: net::ERR_CERT_AUTHORITY_INVALID", "Failed to load resource: net::ERR_CERT_AUTHORITY_INVALID"]
339 | await page.waitForLoadState();
340 |
> 341 | expect(errors).toHaveLength(0);
| ^
342 | }
343 |
344 | test("no console errors on table page", async ({ page }) => {
at checkNoConsoleErrors (/home/reap/Desktop/SQLPage/tests/end-to-end/official-site.spec.ts:341:18)
at /home/reap/Desktop/SQLPage/tests/end-to-end/official-site.spec.ts:357:3
Error Context: test-results/official-site-no-console-errors-on-card-page-chromium/error-context.md
1 failed
[chromium] › official-site.spec.ts:356:5 › no console errors on card page ──────────────────────
21 passed (7.5s)
Serving HTML report at http://localhost:9323. Press Ctrl+C to quit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation
biome check .reports 18 warnings on a clean checkout, so a warning introduced by a new change is easy to miss..claude/settings.local.jsonis checked too, and fails the run outright.Description
!importantfrom the declarations that do not need it.biome-ignorenaming the reason, in the three places that do: leaflet injects its stylesheet after ours, tabler's spacing utilities are themselves!important, and.markdown precaps the height a print rule has to override.mdastToDeltaandopen_modal_for_hash.biome-ignorefornoUnusedVariablesthat no longer matches anything.@ts-ignoreon a typedBuffer.fromcall, and give threeNumber.parseIntcalls their radix..claude/*.jsoninbiome.json, alongside the existing.zed/*.json.Testing
npm testchecks 36 files and reports nothing, where the base reports 18 warnings and 3 infos.no console errors on card pagefails here and on the unmodified base alike: the page loads avatars fromavatars.githubusercontent.com, which this machine cannot verify (ERR_CERT_AUTHORITY_INVALID).GitHub cannot base a pull request on a branch that lives in a fork, so all eight target
mainand each one carries the commits of those above it. Review and merge them in order: