Conversation
Owner
Author
|
Closing duplicate fork-local PR created by validation automation. The intended PR is anomalyco#49993. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Add an optional human-readable reason to legacy and current permission requests, preserve it through request creation, live events, pending APIs, compatibility conversion, public OpenAPI output and generated clients, and display nonblank reasons as plain untrusted text in browser, desktop, TUI and CLI permission prompts without hiding the authoritative command, path or scope. Keep descriptions optional for shell and read compatibility, do not use reason for matching, approval, denial, saved rules or security decisions, do not invent generic built-in reasons when task-specific intent is unavailable, and keep the change limited to permission request reason behavior with no deleted files or unrelated cleanup.
What Changed
Risk Assessment
✅ Low: The change is well-bounded and consistently preserves the optional reason across legacy/current schemas, request creation, events, APIs, compatibility conversion, generated clients, and plain-text UI rendering without affecting permission decisions.
Testing
After linking frozen dependencies with lifecycle scripts disabled, focused permission transport, decision, plugin, CLI, TUI, and app-adaptation checks passed; five browser scenarios also passed live and produced a screenshot showing the reason beside authoritative commands and unchanged controls. Live HTTP API, native desktop, and model-driven CLI/TUI sessions were unavailable, leaving overall validation inconclusive.
shows a pending permission dock~.no-mistakes\evidence\01M2XADT9J2Q4P48KZ75J28ANF\browser-permission-reason.png)Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
shows a pending permission dockbun install --frozen-lockfile(native lifecycle build blocked by missing Visual Studio C++ workload)bun install --frozen-lockfile --ignore-scriptsbun test test/permission.test.tsfrompackages/corebun test test/permission.test.ts --test-name-pattern "preserves an optional reason"frompackages/corebun test test/server/httpapi-v2-location.test.ts --test-name-pattern "preserves a permission reason"frompackages/opencodebun test test/tool/registry.test.ts --test-name-pattern "passes an optional reason"frompackages/opencodebun test test/cli/run/footer.view.test.tsxfrompackages/opencodebun test test/cli/cmd/tui/permission-reason.test.tsxfrompackages/tuibun test --conditions=solid --preload ./happydom.ts src/context/global-sync/utils.test.ts src/context/server-sdk.test.tsfrompackages/appbun x playwright test e2e/regression/session-request-docks.spec.ts --project=chromium --grep "shows a pending permission dock|renders permission reason" --workers=1frompackages/appVisually inspected the captured browser permission prompt screenshot✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.