Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
shabeeth2
marked this pull request as ready for review
September 20, 2026 08:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #47889
Type of change
What does this PR do?
Adds an optional
reasonto permission requests. Requesters with meaningful task-specific intent can explain why approval is needed, and browser/desktop, TUI and CLI prompts display nonblank reasons as plain text beside the authoritative command, path or scope.The field survives request creation, live events, pending APIs, plugin requests, compatibility conversions, the public OpenAPI schema and generated clients. It does not affect permission matching, automatic decisions or saved approval scopes. Built-in read and shell/bash inputs now accept an optional task-specific
reasonand forward it to their permission requests. Omitted reasons remain valid; generic tool descriptions are not copied intoreason.Shell and read descriptions remain optional, preserving compatibility with #26419.
How did you verify your code works?
packages/clientgenerated-output check passed and legacy SDK regeneration was reproducible.git diff --checkpassed and no files were deleted or renamed.App typecheck remains blocked by the existing Windows linked
custom-elements.d.tsresolution problem. The opencode package typecheck reports the pre-existingGlobalBusEmitter.emit/NodeEventEmittersignature incompatibility insrc/bus/global.ts.The final no-mistakes run completed intent, rebase, review, test, documentation, lint and push with no review findings. Its live-test limitation was explicitly accepted because focused executable coverage passed and five browser cases ran live. The CI monitor was cancelled after it bound itself to a duplicate fork-local PR instead of this cross-repository PR; this PR's compliance and standards checks pass.
Screenshots / recordings
Checklist