Skip to content

Propagate errors from custom pretty printers #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −1
Open

Propagate errors from custom pretty printers #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/pp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,11 @@ def pp(obj)
guard_inspect(obj) do
group do
obj.pretty_print self
rescue NoMethodError
rescue NoMethodError => error
raise unless
error.name == :pretty_print &&
error.receiver.equal?(obj) &&
!PP.mcall(obj, Kernel, :respond_to?, :pretty_print)
text Kernel.instance_method(:inspect).bind_call(obj)
end
end
Expand Down
11 changes: 11 additions & 0 deletions test/test_pp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ class PrettyPrintInspectWithoutPrettyPrint
alias inspect pretty_print_inspect
end

class PrettyPrintRaises
def pretty_print(q)
self.missing_from_pretty_print
end
end

class PPInspectTest < Test::Unit::TestCase
def test_hasinspect
a = HasInspect.new(1)
Expand Down Expand Up @@ -157,6 +163,11 @@ def test_basic_object
a = BasicObject.new
assert_match(/\A#<BasicObject:0x[\da-f]+>\n\z/, PP.pp(a, ''.dup))
end

def test_pretty_print_error
error = assert_raise(NoMethodError) { PP.pp(PrettyPrintRaises.new, ''.dup) }
assert_equal(:missing_from_pretty_print, error.name)
end
end

class PPCycleTest < Test::Unit::TestCase
Expand Down