Propagate errors from custom pretty printers - #99
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: PPMethods#pp treats every NoMethodError raised by a custom pretty_print implementation as if the method were absent, silently replacing the failure with generic inspect output. This also hides missing methods called inside the printer and missing super implementations.
Fix: Fall back only when the missing call is exactly pretty_print on the object being rendered and a core respond_to? check confirms the method is absent. Internal printer errors continue to propagate.
Regression coverage: Adds an upstream regression that asserts both the raised exception and missing method name. The combined completion branch passes 42 tests / 64 assertions on Ruby 4.0.6 and 39 / 56 on Ruby 3.2, plus 510 focused model checks on each Ruby.