Repository navigation
feat(server): opt-in open write paths for self-authenticating handlers (#136) - #405
Merged
Merged
Conversation
Member
Author
|
/mira resume |
Contributor
|
/mira pause |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
3 tasks done
rowkav09
force-pushed
the
feat/http-open-write-paths
branch
from
September 24, 2026 12:42
a750d4d to
d1f37d1
Compare
Member
Author
|
No Mira review came in after /mira resume (Mira is still paused). Rebased, tests pass and every check is green. I reviewed it myself: exact-path opt-in only, JSON and body limit still enforced, nothing uses it yet. Merging with an explicit squash message. |
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #136, slice 1b-i. The YouTube extension posts from a
chrome-extension://…origin, so the local server's same-origin and session-cookie checks would refuse it.createHttpServergets anopenWritePathsoption: a list of exact paths whose writes skip those two checks, because the handler authenticates them itself (the bridge from #395 checks the extension origin and the pairing token)./bridge/youtube/or any other path keeps every check). Paths are validated at start-up.application/jsonand are still capped by the body limit.Security note: this is the only way around the write checks, and it's limited to exact paths whose handler does its own auth. The security lane is welcome to review.
Checks