Repository navigation
feat(card): artwork placement and size in the config.json card section (#94) - #400
Merged
Merged
Conversation
#94) card.artworkPosition (left/right), card.artworkWidth (48-160) and card.artworkHeight (48-180) are saved, validated and passed to the renderer. Saving from the settings page keeps them.
Contributor
|
/mira pause |
github-actions
Bot
added
the
mira-paused
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Sep 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #94 (artwork placement and sizing).
The renderer already accepts
artworkPosition,artworkWidthandartworkHeight, but config.json had no way to set them. This adds them to thecardsection:artworkPosition:leftorrightartworkWidth: 48 to 160artworkHeight: 48 to 180Values are checked the same way as the other card settings and passed through to the local card. Saving from the settings page keeps them (it used to rebuild the card section from only the fields it shows). The settings page controls come in a follow-up PR.
Tests:
test/config-card.test.jscovers save/parse, renderer mapping, bad values and settings-page saves.