Repository navigation
fix(updater): Windows installs update from the Windows bundle, not the source tarball (#373) - #374
Merged
Merged
Conversation
…e source tarball (#373)
Contributor
|
/mira pause |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Sep 24, 2026
This was referenced Sep 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #373 (1 of 2: check + download).
What
updateAssetName(version, platform): onwin32it'snowplaying-vX.Y.Z-windows-x64.zip(what release.yml publishes since ci(release): build and attach Windows installer and zip to stable releases (#353) #356). Anywhere else it staysnowplaying-vX.Y.Z.tar.gz.checkForUpdatetakesplatform(defaults toprocess.platform), picks that asset and returnsassetName. A Windows install refuses a release that only has the tarball instead of falling back to it.downloadVerifiedUpdatechecks the digest against theSHA256SUMSline for that exact asset. It only accepts the two names published for that version, so a badassetNamecan't point it at something else. WithoutassetNameit defaults to the tarball, as before.createAutoUpdaterpassesplatformthrough.Existing tests pin
platform: "linux"so they mean the same thing on the Windows CI runner.Tests
npm test: only the existing local sharp-runtime failure (passes in CI).Next PR: install unpacks and validates the Windows bundle, plus an end-to-end check -> download -> swap test.