VM test: keep the VNC socket path under the Unix socket limit - #1883
Merged
Merged
Conversation
linux-checks.sh (now run in repo-hygiene, #1821) sets TMPDIR to build/linux-checks/tmp inside the checkout. On CI that puts the test's $ROOT/home/.transcripted-vm/run/upvm.vncsock past Linux's 108-byte socket path limit, so the six approve-download cases fail on every PR. When the temp root is too deep, use a short /tmp/tvm.XXXXXX root instead; the EXIT trap still removes it. Checked: 63/63 with TMPDIR at a CI-length path (was 52/63). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
r3dbars
added a commit
that referenced
this pull request
Sep 28, 2026
Picks up the VM test socket-path fix (#1883) and everything merged today. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
r3dbars
added a commit
that referenced
this pull request
Sep 28, 2026
Picks up the VM test socket-path fix (#1883) and everything merged today. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
r3dbars
added a commit
that referenced
this pull request
Sep 28, 2026
Picks up the VM test socket-path fix (#1883) and everything merged today. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
r3dbars
added a commit
that referenced
this pull request
Sep 28, 2026
Picks up the VM test socket-path fix (#1883) and everything merged today. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
r3dbars
added a commit
that referenced
this pull request
Sep 28, 2026
Same bug as #1883, in the other VM test: linux-checks.sh points TMPDIR deep inside the checkout, which put vnc.py's self-test socket past the 104-byte macOS cap, so 'serve never opened its socket' failed every linux-checks run in a worktree while the standalone run passed. Use a short /tmp directory when the temp root is long. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1821, repo-hygiene runs
scripts/dev/linux-checks.sh, and every PR fails its "clean VM script guards" step (first seen on #1761). Sixapprove-downloadcases fail withOSError: AF_UNIX path too long.Why
linux-checks.shsetsTMPDIRtobuild/linux-checks/tmpinside the checkout, to keep side effects underbuild/. On a GitHub runner, the test's VNC socket then lands at/home/runner/work/transcripted/transcripted/build/linux-checks/tmp/tmp.XXXXXXXXXX/home/.transcripted-vm/run/upvm.vncsock. That's about 120 bytes, past Linux's 108-byte limit for a Unix socket path (macOS allows 104).Fix
If the temp root is too deep for that socket path, the test uses a short
/tmp/tvm.XXXXXXroot instead. The existingEXITtrap still removes it. Test-only;transcripted-vm.shis unchanged.How I checked it
bash scripts/vm/test-transcripted-vm.shwithTMPDIRat a CI-length path: 63 passed, 0 failed (52/63 before)/tmp/tvm.*folders left behind afterwards🤖 Generated with Claude Code