Repository navigation
CI: run the Linux checks in repo-hygiene, rename the Lab job - #1821
Merged
Merged
Conversation
…-test repo-hygiene now runs scripts/dev/linux-checks.sh --strict-tools as its first step (text-pin mirror, telemetry-key check, script self-tests), so a broken pin shows up in seconds instead of after the macOS run. The Lab workflow's job was named build-and-test, the same name as Swift CI's required umbrella check, so a Lab-only green could satisfy the required check. Renamed to lab-build-and-test. Split out of #1805 because the Claude GitHub app cannot merge workflow-file changes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GhNAWeNXuLGdq4ioddevdp
r3dbars
marked this pull request as ready for review
September 24, 2026 06:58
2 tasks done
r3dbars
added a commit
that referenced
this pull request
Sep 28, 2026
linux-checks.sh (now run in repo-hygiene, #1821) sets TMPDIR to build/linux-checks/tmp inside the checkout. On CI that puts the test's $ROOT/home/.transcripted-vm/run/upvm.vncsock past Linux's 108-byte socket path limit, so the six approve-download cases fail on every PR. When the temp root is too deep, use a short /tmp/tvm.XXXXXX root instead; the EXIT trap still removes it. Checked: 63/63 with TMPDIR at a CI-length path (was 52/63). Co-authored-by: r3dbars <r3dbars@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Justin · project thread
Needs a human to merge. The Claude GitHub app can't merge changes to
.github/workflows/. That's why these two edits were split out of #1805, which is already merged.Why
Before, there were two problems:
repo-hygienedidn't runscripts/dev/linux-checks.sh, so a broken Swift text pin only showed up after the ~20-minute macOS run.build-and-test, the same name as Swift CI's required check. On Agent-friendly repo: fixed guides, Linux checks, text-pin and telemetry-key checkers #1805, a Lab-only run showed a greenbuild-and-testwhile Swift CI was still queued.After this PR:
repo-hygienerunslinux-checks.sh --strict-toolsfirst, so broken pins and dropped telemetry keys fail in seconds.lab-build-and-test, so only Swift CI can satisfy the required check.Product Impact
agent workflowWhat changed
.github/workflows/repo-hygiene.yml: one new step after Checkout. The existing inline steps are unchanged, so the open PRs that add hygiene steps still merge cleanly..github/workflows/transcripted-lab.yml: the job id is renamed, with a comment explaining why.CLAUDE.md,docs/test-automation-strategy.md, and thelinux-checks.shcomments now sayrepo-hygieneruns the script.How I checked it
bash scripts/dev/linux-checks.sh --strict-tools: 48 pass, 0 fail, 1 skip (release gate; no release surface touched)repo-hygieneon Agent-friendly repo: fixed guides, Linux checks, text-pin and telemetry-key checkers #1805's earlier heads (a5bb291, 17454a2).Checks I could not run: none needed on the Mac; no Swift changed.
Risk Review
🤖 Generated with Claude Code
https://claude.ai/code/session_01GhNAWeNXuLGdq4ioddevdp
Generated by Claude Code