Repository navigation
Menu rows answer an accessibility press before acting - #1865
Merged
Merged
Conversation
A row that opens a window or closes the popover held the accessibility caller past its timeout, so the release UI smoke saw 'Could not press the Open Transcripted row' even though the action ran. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126tPTsXGHmWx6EmsR32sjX
r3dbars
marked this pull request as ready for review
September 25, 2026 18:22
r3dbars
pushed a commit
that referenced
this pull request
Sep 25, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CbeBca5tWoYd38bopu4dF1
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
https://claude.ai/code/session_0126tPTsXGHmWx6EmsR32sjX
Why
The 1.1.66 release UI smoke failed at "Could not press the Open Transcripted row." (
Tools/TranscriptedQA/.../UISmoke.swift"open-home" check). The menu row ran its action (open a window, close the popover) insideaccessibilityPerformPress(), so the accessibility caller waited past its timeout and saw a failed press even though the action ran. VoiceOver users hit the same thing.Product Impact
dictation/meetings(menu bar rows)release opsWhat changed
MenuBarActionRowView.accessibilityPerformPress()returnstrueright away and runs the row's action on the next main-queue turn. Mouse and keyboard presses are unchanged (still synchronous).How I checked it
bash scripts/dev/linux-checks.sh(runs without Swift) — 48 passedpython3 scripts/dev/check-source-pins.py --changed-onlyPASS;Tests/UIAutomationSurfaceContractTests.swift:120still findsoverride func accessibilityPerformPress()bash build.sh --no-open/bash run-tests.sh— CIChecks I could not run, and why:
Mac or hardware test still needed? If yes:
mainwith "Could not press the Open Transcripted row."). The Release 1.1.66 thread owns that run.Risk Review
Notes
Patch came from the Release 1.1.66 thread. Do not merge until that thread asks; main is frozen until 1.1.66 is cut.
Agent handoff
COORD_DONE: BRIEF | this PR | 1-line menu row a11y press fix | none | merge only when Release 1.1.66 asks | linux-checks, source pins | CI + deep reviewGenerated by Claude Code