Skip to content

Fixed scope override inside metafunc.parametrize. Fixes #634 - #1766

Merged
nicoddemus merged 1 commit into
pytest-dev:masterfrom
Stranger6667:issue634-scopes
Jul 25, 2016
Merged

nicoddemus merged 1 commit into
pytest-dev:masterfrom
Stranger6667:issue634-scopes

Conversation

@Stranger6667

@Stranger6667 Stranger6667 commented Jul 25, 2016 •

Copy link
Copy Markdown
Contributor

Hello, this is my initial approach to solve #634
I'm not very familiar with pytest codebase, so I'll appreciate any help here.
Thank you

P.S. Also #684 #661 #896 #531 are probably related to this issue

@coveralls

coveralls commented Jul 25, 2016 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.004%) to 92.296% when pulling af362b3 on Stranger6667:issue634-scopes into d37af20 on pytest-dev:master.

@coveralls

coveralls commented Jul 25, 2016 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.004%) to 92.296% when pulling e686f39 on Stranger6667:issue634-scopes into d37af20 on pytest-dev:master.

@RonnyPfannschmidt

Copy link
Copy Markdown
Member

@Stranger6667 good work, at first glance it indeed seems to solve quite many if not all of the related issues

@coveralls

coveralls commented Jul 25, 2016 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.004%) to 92.301% when pulling d72afe7 on Stranger6667:issue634-scopes into a2b04d0 on pytest-dev:master.

@nicoddemus
nicoddemus merged commit d72afe7 into pytest-dev:master Jul 25, 2016
@nicoddemus

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants