pytest_generate_tests doesn't play with pytest.mark.parametrize #896

Activity

1. pfctdayelise

   added

   topic: parametrizerelated to @pytest.mark.parametrizerelated to @pytest.mark.parametrize

   on Jul 27, 2015
2. philpep

   added a commit that references this issue on Jul 29, 2015

   Don't use pytest_generate_tests

   ...

   9933a87
3. RonnyPfannschmidt commented on Sep 13, 2015

   

   RonnyPfannschmidt

   on Sep 13, 2015

   Member

   More actions

   @philpep does this also happen when using indirect=True?
4. A-A-Ron-Diver commented on Sep 16, 2015

   

   A-A-Ron-Diver

   on Sep 16, 2015

   More actions

   I've run into the same issue. I've found that it doesn't have to use both pytest_generate_tests and pytest.mark.parametrize. The issue comes about with any fixture that uses a parametrized parameter, along with another parametrized parameter being used in the same test function.
   The following reproduces the above example but with using only pytest_generate_tests:

   import pytest
   
   CALL_COUNT = 0 
   
   def pytest_generate_tests(metafunc):
       if "fixture_param" in metafunc.fixturenames:
           metafunc.parametrize("fixture_param", ["foo"], scope="module")
       if "test_param" in metafunc.fixturenames:
           metafunc.parametrize("test_param", ["bar", "zaz"], scope="module")
   
   @pytest.fixture(scope="module")
   def fixture(fixture_param):
       global CALL_COUNT
       CALL_COUNT += 1
   
   
   def test_1(fixture, test_param):
       global CALL_COUNT
       assert CALL_COUNT == 1
   
5. bounceconnection commented on Mar 7, 2016

   

   bounceconnection

   on Mar 7, 2016

   More actions

   I'm running into this issue as well, is there a workaround for this?
6. philpep commented on Mar 28, 2016

   

   philpep

   on Mar 28, 2016

   Author

   More actions

   @RonnyPfannschmidt indeed that doesn't occur with indirect=True

   This test pass:

   import pytest
   
   CALL_COUNT = 0 
   
   
   @pytest.fixture(scope="module")
   def fixture(request):
       global CALL_COUNT
       CALL_COUNT += 1 
   
   
   def pytest_generate_tests(metafunc):
       if "fixture" in metafunc.fixturenames:
           metafunc.parametrize("fixture", ["foo"], indirect=True, scope="module")
   
   
   @pytest.mark.parametrize("param", ["bar", "zaz"])
   def test_1(fixture, param):
       global CALL_COUNT
       assert CALL_COUNT == 1
7. Stranger6667 commented on Jul 26, 2016

   

   Stranger6667

   on Jul 26, 2016

   Contributor

   More actions

   Unfortunately #1766 didn't fix the issues here :(
8. RonnyPfannschmidt commented on Jun 2, 2017

   

   RonnyPfannschmidt

   on Jun 2, 2017

   Last edited by RonnyPfannschmidt

   Member

   More actions

   import pytest
   import os
   
   HAS_CAR = bool(os.environ.get("HAS_CAR"))
   
   
   def pytest_generate_tests(metafunc):
       if 'car' in metafunc.fixturenames:
           metafunc.parametrize(
               'car', ['red', 'green'],
               scope='module', indirect=HAS_CAR)
   
   
   if HAS_CAR:
       @pytest.fixture(scope='module')
       def car(request):
           return request.param
   
   
   @pytest.yield_fixture(scope='module')
   def prepared_car(car):
       print("\n{} CAR PREPARED".format(car))
       yield car
       print("\n{} CAR TAKEN AWAY".format(car))
   
   
   @pytest.mark.parametrize('wheel', [1, 2, 3], scope='function')
   def test_car_wheels(prepared_car, wheel):
       print("CHECKING {} CAR, WHEEL NUMBER {}".format(prepared_car, wheel))
   
   
   def test_car_steering(prepared_car):
       print("CHECKING {} CAR, STEERING WHEEL".format(prepared_car))

   is a more extended example
9. Zac-HD

   added

   topic: fixturesanything involving fixtures directly or indirectlyanything involving fixtures directly or indirectly

   on Jun 22, 2019
10. jpsnyder commented on Nov 8, 2021

    

    jpsnyder

    on Nov 8, 2021

    Last edited by jpsnyder

    More actions

    It looks like I am running into this issue too, which is causing my heavy setup/teardown to be run on each function instead of per session.
    Is there any workaround for this?
11. Zac-HD

    closed this as completedin #14746on Jul 27, 2026