Skip to content

[release] should not check (all) links #6612

Closed

Description

@blueyed

tox -e release -- … triggers the link checking, which is very slow.

This should only be done on demand I think.

There's an option to skip it: https://github.com/blueyed/pytest/blob/059bf16d09dde7720876fae67a1f096b401137ac/scripts/release.py#L118

Activity

  1. changed the title [-][release]: should not check links[/-] [+][release] should not check (all) links[/+] on Jan 29, 2020
  2. nicoddemus commented on Jan 29, 2020

    @nicoddemus
    Member

    I was a bit concerned about this as well, but after making the release a few times I don't really seem to notice (takes less than 3 minutes or so).

  3. The-Compiler commented on Jan 30, 2020

    @The-Compiler
    Member

    FWIW we've already had this discussion in #1722.

    If only doing it on demand, I bet nobody will ever do it 😉 Like @nicoddemus said, if it's not a problem when releasing in practice, I don't see why it should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: infrastructureimprovement to development/releases/CI structure

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions