You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Anyone working on this ? I would like to work on this.
I'm a first time contributor, and may require a bit of help, especially how to test the change etc. (Relevant code snippet and possible solution already provided by @Zac-HD - Thanks.)
Is https://docs.pytest.org/en/latest/adopt.html (April 2015 is "adopt pytest month") still needed? It is still in the repo and contains a broken link (to google forms). Can this be deleted? If not, what can I with the link?
@steffenschroeder I'd keep it around - it's nice to know it was a thing that happened, and we should probably do that again some day! Which of the links is broken? The two form links I see there seem to work fine. I'd probably just remove the link and maybe strike through the text or so.
@The-Compiler the Partner projects, sign up here! is broken an can probably be removed (or strike through).
The assert, markers and distributed links could be changed to proper locations. Will do so.
@steffenschroeder Odd, that link seems to be okay - it leads to a The form "Request a helper for your open source project, for "adopt pytest month"" is no longer accepting responses.-page, but that's not a 404 or anything, so I wonder why linkcheck complains about it. Either way, seems fine to remove the text.
Activity
nicoddemus commentedon Jul 13, 2016
Does anyone have a suggestion on how to do this? I took a look at rst-lint we use and it does not have that option.
The-Compiler commentedon Jul 13, 2016
LinkChecker maybe? Hopefully it also runs locally over the generated HTML files.
If we do this with Travis we probably shouldn't do it on every push though.
nicoddemus commentedon Jul 13, 2016
Hmm sounds good. Why do you say we shouldn't do it on every push? So people's PRs are not blocked if some unrelated link is broken?
Sad panda is sad.
The-Compiler commentedon Jul 13, 2016
No, because it's not very nice to do dozens (hundreds?) of HTTP request with every push 😉 I guess we could use Travis' cron feature?
RonnyPfannschmidt commentedon Jul 13, 2016
should we make it part of the pre-release process?
nicoddemus commentedon Jul 13, 2016
Heh, right. 😝
Good idea. A simple environment on tox that should be part of the release process sounds good, executed locally.
adamtheturtle commentedon Aug 26, 2016
In case it saves you a few minutes, https://github.com/jenca-cloud/jenca-authentication/blob/master/.travis.yml#L16 is a
.travis.ymlwhich only installs and runslinkcheckeron Python 3 builds.nicoddemus commentedon Aug 26, 2016
Thanks @adamtheturtle!
The-Compiler commentedon Sep 20, 2016
Seems like Sphinx also has a linkcheck builder built-in.
Zac-HD commentedon Dec 5, 2018
An easy contribution would be to run the Sphinx
linkcheckbuilder fromrelease.py, after thefix_formatting()step.mandarvaze commentedon Jun 3, 2019
Anyone working on this ? I would like to work on this.
I'm a first time contributor, and may require a bit of help, especially how to test the change etc. (Relevant code snippet and possible solution already provided by @Zac-HD - Thanks.)
4 remaining items
mandarvaze commentedon Jun 3, 2019
Understood. I can do what @blueyed suggested.
Do you mean update
HOWTORELEASE.rst?or
call it from
release.pyas you suggested above ?nicoddemus commentedon Jun 6, 2019
@mandarvaze just call it from
release.pyshould be fine. 👍Added checklinks to tox and release.py
steffenschroeder commentedon Jul 13, 2019
started to working on this during EuroPython2019 sprint. (with the help of @The-Compiler)
Will open 2 PRs:
steffenschroeder commentedon Jul 13, 2019
Is https://docs.pytest.org/en/latest/adopt.html (
April 2015 is "adopt pytest month") still needed? It is still in the repo and contains a broken link (to google forms). Can this be deleted? If not, what can I with the link?The-Compiler commentedon Jul 15, 2019
@steffenschroeder I'd keep it around - it's nice to know it was a thing that happened, and we should probably do that again some day! Which of the links is broken? The two form links I see there seem to work fine. I'd probably just remove the link and maybe strike through the text or so.
steffenschroeder commentedon Jul 15, 2019
@The-Compiler the
Partner projects, sign up here!is broken an can probably be removed (or strike through).The assert, markers and distributed links could be changed to proper locations. Will do so.
Added checklinks to tox and release.py
Added checklinks to tox and release.py
The-Compiler commentedon Jul 16, 2019
@steffenschroeder Odd, that link seems to be okay - it leads to a The form "Request a helper for your open source project, for "adopt pytest month"" is no longer accepting responses.-page, but that's not a 404 or anything, so I wonder why linkcheck complains about it. Either way, seems fine to remove the text.
Added checklinks to tox and release.py
steffenschroeder commentedon Jul 16, 2019
@The-Compiler although the link works in the browser,
checklinkswill report it as an error. So I have 2 options:For this particular case, I removed it.
Added checklinks to tox and release.py
steffenschroeder commentedon Jul 17, 2019
#5614 will add link checking for all links in the documentation.
The check will only be done locally during the release process (release.py)
#5613 will correct all broken links the linkchecker found.