fix(runtime): empty Claude home continuation, ACP session start stderr, and SnapShot GTK4 text - #684
Merged
Merged
Conversation
… (#12624) (cherry picked from commit 63ff33756c47f127391962458d8388a647e8ed44)
…art (#12625) Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit d6f291303ddc0c9a14f570266a4d9eff6d431593)
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 52d08a14b9e475371658fabbb12c056c3d3dad67)
…olve Claude config env
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts upstream runtime fixes for Claude home directory continuation, ACP session startup error reporting, and Linux SnapShot accessibility context from Cycle #682 Group B.
Upstream Sources
63ff33756c(#12624): Empty ClaudehomePathshares continuation and capability caches with~/.claudeor inheritedCLAUDE_CONFIG_DIRrather than bare home.d6f291303d(#12625): Surface ACP stderr tail whencursor-agentor other ACP agents exit at session start, replacing generic "adapter thread is closed" errors with the agent's real startup failure message.52d08a14b9(#12635): Include SnapShot app text for Flatpak and GTK4 apps where compositor PID scoping misses or AT-SPI proxy mappings are required.Pylon Invariants & Adversarial Review Hardening
sanitizeAcpStderrExcerptto redact OAuth tokens, cookies, auth headers, and user home directory paths.maxStderrLineLengthto prevent memory leaks on long newline-free streams.resolveClaudeCredentialConfigDirinclaudeOAuthUsage.tsaligns withClaudeHome.tsby respecting inheritedCLAUDE_CONFIG_DIRwhenhomePathis empty.SnapShotAccessibility.tsto prevent overlapping OS accessibility calls.Closes #682
Part of Cycle #682 (with #683)
Verification
pnpm typecheck: Passed (0 errors across workspace)pnpm --filter t3 test src/provider/Drivers/ClaudeHome.test.ts src/provider/acp/AcpStderr.test.ts src/provider/acp/AcpAdapterSupport.test.ts src/provider/acp/AcpJsonRpcConnection.test.ts: Passed (34/34 tests)pnpm --filter @t3tools/desktop test src/snapShot/DesktopSnapShot.test.ts src/snapShot/snapShot.test.ts: Passed (191/191 tests).agents/upstream-review.mdupdated.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.