Skip to content

refactor!: remove python2 - #856

Closed
kuwv wants to merge 8 commits into
pyinvoke:mainfrom
kuwv:deprecate-python2
Closed

kuwv wants to merge 8 commits into
pyinvoke:mainfrom
kuwv:deprecate-python2

Conversation

@kuwv

@kuwv kuwv commented Apr 17, 2022 •

Copy link
Copy Markdown
Contributor

Python 2 has been deprecated for over a year now. This pull request removes integrations with invoke with six that are used to support now deprecated Python2 compatibility. Removing this will allow builds to be more simplified while allow integration with more modern tooling from the Python ecosystem.

see corresonding: pyinvoke/invocations#30

@kuwv kuwv changed the title Deprecate python2 refactor!: remove python2 Apr 17, 2022
@kuwv

kuwv commented Apr 18, 2022 •

Copy link
Copy Markdown
Contributor Author

Tests need to be run with corresponding invocations that also has six removed.

@neozenith

Copy link
Copy Markdown

@kuwv Thanks for openning this, but @bitprophet is actively working on removing Python 2 (after a long time of dealing with other priorities than FOSS).

The migration of invoke, fabric and paramiko from Travis to CircleCI was a blocker which is now complete.

He is working on removing Python 2 from invoke first since it has least dependencies and Fabric and paramiko depend on Invoke.

@bitprophet

bitprophet commented Apr 23, 2022 •

Copy link
Copy Markdown
Member

What @neozenith said, though so far I've only started on Invocations myself (I think before that PR over there was filed). So you may want to just close that one, but I'll make a note to build off this one when I turn my attention to Invoke-proper.

As with any PR, I may end up using a scalpel, but especially for this kind of more grunt-work it'll save me a lot of time regardless, so thank you!

@kuwv

kuwv commented Apr 24, 2022

Copy link
Copy Markdown
Contributor Author

@bitprophet, @neozenith, glad this will be useful then. I'll close the invocations PR.

@kuwv

kuwv commented Apr 24, 2022 •

Copy link
Copy Markdown
Contributor Author

One caveat, I updated to pep517 build for setuptools.

Use:

python -m build

instead of:

python setup.py build

Also,
dev-requirements.txt contains link to invocations for testing that is not intended for merging.

@kuwv

kuwv commented Dec 5, 2022

Copy link
Copy Markdown
Contributor Author

@neozenith Do you need me to refresh this? Or, do you have a time frame?

@bitprophet

Copy link
Copy Markdown
Member

Gonna take a crack at applying this now and hope it saves me some time! 🙏🏻 Invoke is now up on my Py2 chopping block.

@bitprophet

Copy link
Copy Markdown
Member

Rebased onto latest main, made some minor changes, and merged back into main. I'll take the rest from here - thanks! 🙌🏻

@bitprophet bitprophet closed this Jan 6, 2023
@kuwv

kuwv commented Jan 7, 2023

Copy link
Copy Markdown
Contributor Author

Huzzah!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants