Repository navigation
Conversation
As mentioned in pyinvoke#357 - using `getfullargspec` as recommended in the error itself.
...for python 2.7 and pypy
had previously attempted to match coding style with one-liner - black was not amused. Black's suggestion was to use parens and make the statement multi-line, which isn't correct, IMO. Abandoned the code style and went with a shorter one-liner.
|
@toejough what's the status of this PR? I also would like type annotations to be fixed. |
|
I'm actually working entirely in Go these days. I'm not impacted by this anymore, but it looks like a lot of people still are. @bitprophet, would you accept this PR? I'm happy to make any final adjustments necessary to push it across the finish line. |
|
Would love to see progress on this - have been using the monkey patch successfully until now |
|
merge? |
|
Can this please be merged? |
|
@bitprophet could you please review/merge this? |
|
Can this be merged? |
|
Hi 👋 The messaging for the roadmap can be found here: Key items that are putting back pressure are:
The latter task is the more important task which will make future type annotation support easier. Given this PR has a high number of 👍 votes on it I'll take that as community feedback it has good ROI for me to investigate. We do appreciate everyone's patience as we have limited volunteering time and cognitive bandwidth. |
|
@bitprophet please ? |
|
Is this being held back on purpose for some reason? The PR seems to be reasonable to me... the error message says how to fix it... At what point does the project need to say it is compatible with Python2.7 and Python 3.4 only instead of 3.4+? |
|
Hi, a quick update, I have personally had to take a back seat from OSS the last few months due to work. I haven't caught up with bitprohet in a while but I know that he had some events going on his life which meant he had significantly less bandwidth for OSS too. Whilst this might seem like a simple PR to merge, it is also balancing the ownership of support requests if it negatively impacts others after the release. Which is on bitprophet and the pyinvoke team, not the PR contributor. The bigger context is that Invoke is coupled with Fabric and Paramiko projects too. The next highest priority task for all three projects is dropping support for Python 2 and likely < Python 3.6. https://bitprophet.org/projects/#roadmap Once we get bandwidth back, that is where we will be focusing our energy. I realise this is not the response you would be hoping for but that is the reality of why "do nothing" is a deliberate choise for now. Help on the open PR to drop Python 2 would be appreciated to make it easier to drop these bugs with a smaller test matrix. |
Definitely not what I WANTED, but you have brought me the gift of context, and I appreciate that a lot!
I will see if I can get some time carved out to help while I am working, see if there is anything I can help with. Last time I touched Paramiko, I .... really didn't want to anymore, but shells and ssh are complicated, so a lot of it is unavoidable. If I can't get some time to help contribute, I will push on maybe we (my work) can contribute to the project via Tidelift |
Requires pyinvoke/invoke#606
Invoke doesn't work with Python 3.11 so far. pyinvoke/invoke#833 (comment) pyinvoke/invoke#458 pyinvoke/invoke#606
As mentioned in #357 - using
getfullargspecas recommended in the error itself.This change is