Repository navigation
Fix test_offline's tearDown - #3691
Merged
nicolaskruchten merged 1 commit intoMay 1, 2022
Merged
nicolaskruchten merged 1 commit into
nicolaskruchten merged 1 commit into
Conversation
Contributor
|
Thanks very much! Indeed the build-doc step was failing for unrelated reasons :) |
BjoernLudwig
deleted the
fix_missing_teardowns_for_errorless_subsequent_test_suite_runs
branch
May 2, 2022 18:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #3690 we discovered that subsequent runs of the test suite produced an error due to incorrect tear down behaviour in test_offline.py. At least this is, what we think is the cause and our fix solved the issue for us.
What had happened:
On 03.06.2019 John Mease introduced some chages in 2a44ce3 including several new tearDown methods for instance for
class PlotlyOfflineTestCase(PlotlyOfflineBaseTestCase). The problem with this particular newtearDown()was, that since then it has overridden the parent class tear down method, which was cleaning up after some of the tests. The residual files cause two failing tests on subsequent runs without the introduced patch, which now calls the parent class tearDown in John Mease's from 2019.This is my second contribution to Plot.ly, so please let me know, if I can improve anything.
As of now the
build-docjob keeps failing although I have the impression, that this is unrelated to my changes. Please let me know, if I can do anything to fix this.Code PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).