Repository navigation
refactor pandas df.append to pd.concat w/ asserts - #3690
Merged
nicolaskruchten merged 4 commits intoMay 2, 2022
Merged
nicolaskruchten merged 4 commits into
nicolaskruchten merged 4 commits into
Conversation
2 of 5 tasks
Contributor
|
Thank you very much for this much-needed PR! I will try to review it in the next 10 days or so, ahead of the next release :) |
Contributor
|
This looks perfect to me! Could you please merge master into this branch and then I can merge? |
Contributor
|
I think I can actually just merge this in, no further action needed :) |
Author
|
Thanks so much. It is a great pleasure to contribute to such an amazing project! Awesome to now be a part of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #3602 by replacing all pandas'
df.append()calls bypd.concat()calls in alignment with the corresponding 1.4.0 Release Notes. Since there should be no functionality affected, no bug fixed, no interface changed or similar whatsoever, we only changed the according calls inplotly.expressandplotly.figure_factory. To make sure we did in fact not change the intermediate results of these calls, we temporarily kept the old calls in, and asserted them equaling our new calls topd.concat(). Locally all tests passed and after successful pipeline runs we removed these assertions and the old calls, to finally get rid of theFutureWarnings.This is my first contribution to Plot.ly, so please let me know, if I can improve anything.
As of now the
build-docjob keeps failing although I have the impression, that this is unrelated to my changes. Please let me know, if I can do anything to fix this.Code PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).