Repository navigation
fix(web,mobile): limit bars keep the even-spending tick visible - #16937
charlielockyer-rice wants to merge 5 commits into
Conversation
The even-spending marker on limit bars was a 1px line at 60% opacity. It overhung the bar and disappeared over same-colored fills, such as Codex's bar in either theme, in the /usage-limits result on web and in limit rows on mobile. It is now a 2px tick in a gap cut through the bar, kept inside the bar's ends. Web cuts the gap with a CSS mask so it also works on the composer's translucent surface; mobile clips the bar either side of the tick. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedOnly developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Next included review available in 13 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped visual fix for the existing usage-limit bars on web and mobile. It changes only marker masking, clamping, and presentation while preserving usage calculations and surrounding behavior, with no product-default or static-analysis changes. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
|
Taking over this one for batch usage-billing-04. I’ll rebuild the focused rendering fix against current main, keep only useful tests, and run independent reviews before publishing. No merge is planned. |
Dismissing prior approval to re-evaluate 1cf4d4b
|
Merged current main after #14477 in 0c7b030, preserving branch history. The individual-bar gap/tick behavior stays; both bars now use the shared pace helper. All pooled marks, accessibility, detail rows, label clipping, and refill hatching from the merged PR are retained unchanged. 169 focused tests, nine pooled/refresh browser tests, scoped lint/format, and shared/web/mobile typechecks pass. Fresh parallel Opus and Sol reviews found no blockers. The PR body now includes refreshed current-main versus merged-head evidence and native verification limits. Leaving this unmerged and watching CI on the new head. |
|
Thanks @charlielockyer-rice. The gap-and-tick treatment from this PR is what the maintainer wanted, and it landed in #22408 (which credits this PR) applied to all four Limits bars on web and mobile, including the pooled segments this PR did not cover. Closing this one as superseded rather than merging it on top. |
The even-spending marker disappears inside a foreground-colored usage-limit fill. Web and mobile composer /usage-limits bars now draw an opaque 2px tick in a narrow transparent gap, kept inside the bar at either endpoint. Unknown timing leaves the bar continuous. Percentages, pace, reset times, and provider colors retain their existing calculations.
Updated onto current main after #14477 landed, using a merge commit to preserve the contributor branch history. Both individual bars use the new shared pace helper while retaining this PR's gap and tick rendering. Main's pooled pace marks, accessible descriptions, Even pace details, label/countdown clipping, and partial-refill hatching are preserved unchanged. The diff against main remains limited to the two individual-bar components.
Credit to @charlielockyer-rice for the original design and implementation in #16937. Maintainer takeover claim.
Verification:
These captures use actual LimitWindows and UsageLimitsPooled source components in an isolated Vite fixture with a DejaVu font, rather than a full authenticated composer flow. Native iOS/Android, Safari, macOS, Windows, and packaged Electron were not exercised on this Linux machine. Mobile clipping still needs native visual confirmation.
Implementation: gpt-6.1-sol through Codex. Tests: gpt-6-astra through Codex. Independent full-diff reviews: claude-opus-5-5 through Claude Code and gpt-6-sol through Codex.