Skip to content

test(web): remove duplicate sidebar ordering tests #14558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 2 commits into from
Oct 1, 2026
Merged

test(web): remove duplicate sidebar ordering tests #14558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c7250f
test(web): remove duplicate sidebar ordering tests
t3-code[bot] Oct 1, 2026
a5a6530
fix(web): drop unused sidebar re-export
t3-code[bot] Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 0 additions & 100 deletions apps/web/src/components/Sidebar.logic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ import {
sortLogicalProjectsForSidebar,
resolveSidebarDropTarget,
pinOrderKeyBetween,
planPinnedReorder,
planSidebarThreadDrop,
sidebarMarkerId,
sidebarListItemId,
Expand Down Expand Up @@ -958,59 +957,6 @@ describe("reduceSidebarProjectScopeMenuState", () => {
});
});

describe("sortThreadsForSidebar", () => {
const sortable = (input: { id: string; createdAt: string }) => ({
id: input.id,
createdAt: input.createdAt,
});

it("orders by creation time, newest first, ignoring activity", () => {
const sorted = sortThreadsForSidebar([
sortable({ id: "oldest", createdAt: "2026-03-09T08:00:00.000Z" }),
sortable({ id: "newest", createdAt: "2026-03-09T12:00:00.000Z" }),
sortable({ id: "middle", createdAt: "2026-03-09T10:00:00.000Z" }),
]);

expect(sorted.map((thread) => thread.id)).toEqual(["newest", "middle", "oldest"]);
});

it("breaks creation-time ties by id so the order is stable", () => {
const sorted = sortThreadsForSidebar([
sortable({ id: "b", createdAt: "2026-03-09T10:00:00.000Z" }),
sortable({ id: "a", createdAt: "2026-03-09T10:00:00.000Z" }),
]);

expect(sorted.map((thread) => thread.id)).toEqual(["a", "b"]);
});

it("surfaces an un-settled thread at the top via its re-entry stamp", () => {
const sorted = sortThreadsForSidebar([
{
id: "old-unsettled",
createdAt: "2026-03-09T08:00:00.000Z",
unsettledAt: "2026-03-09T13:00:00.000Z",
},
sortable({ id: "newest", createdAt: "2026-03-09T12:00:00.000Z" }),
sortable({ id: "middle", createdAt: "2026-03-09T10:00:00.000Z" }),
]);

expect(sorted.map((thread) => thread.id)).toEqual(["old-unsettled", "newest", "middle"]);
});

it("ignores a re-entry stamp older than the thread's creation", () => {
const sorted = sortThreadsForSidebar([
{
id: "stale-stamp",
createdAt: "2026-03-09T10:00:00.000Z",
unsettledAt: "2026-03-09T09:00:00.000Z",
},
sortable({ id: "newest", createdAt: "2026-03-09T12:00:00.000Z" }),
]);

expect(sorted.map((thread) => thread.id)).toEqual(["newest", "stale-stamp"]);
});
});

describe("pinOrderKeyBetween", () => {
it("produces keys that sort between their bounds", () => {
const middle = pinOrderKeyBetween(null, null)!;
Expand Down Expand Up @@ -1062,52 +1008,6 @@ describe("pinOrderKeyBetween", () => {
});
});

describe("planPinnedReorder", () => {
it("writes only the moved thread when neighbors are keyed", () => {
const assignments = planPinnedReorder({
orderedIds: ["a", "c", "b"],
keysById: new Map([
["a", "f"],
["b", "m"],
["c", "t"],
]),
movedId: "c",
});
expect(assignments).toHaveLength(1);
expect(assignments[0]!.id).toBe("c");
expect(assignments[0]!.orderKey > "f" && assignments[0]!.orderKey < "m").toBe(true);
});

it("treats list edges as open bounds", () => {
const assignments = planPinnedReorder({
orderedIds: ["b", "a"],
keysById: new Map([
["a", "m"],
["b", null],
]),
movedId: "b",
});
expect(assignments).toHaveLength(1);
expect(assignments[0]!.orderKey < "m").toBe(true);
});

it("materializes keys for the whole section when a neighbor is keyless", () => {
const assignments = planPinnedReorder({
orderedIds: ["b", "a", "c"],
keysById: new Map([
["a", null],
["b", "m"],
["c", null],
]),
movedId: "b",
});
expect(assignments.map((entry) => entry.id)).toEqual(["b", "a", "c"]);
const keys = assignments.map((entry) => entry.orderKey);
expect([...keys].sort()).toEqual(keys);
expect(new Set(keys).size).toBe(keys.length);
});
});

describe("resolveSidebarDropTarget", () => {
const thread = (key: string, section: SidebarSection): SidebarListItem => ({
kind: "thread",
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/Sidebar.logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,7 @@ export { sortActiveThreadsByOrderKey as sortThreadsForSidebar } from "@t3tools/c

// Pinned-reorder key math and the keyed sort live in client-runtime
// (state/thread-sort) so web and mobile compute identical pinned orders.
export { pinOrderKeyBetween, planPinnedReorder } from "@t3tools/client-runtime/state/thread-sort";
export { pinOrderKeyBetween } from "@t3tools/client-runtime/state/thread-sort";
export { sortPinnedThreadsByOrderKey as sortPinnedThreadsForSidebar } from "@t3tools/client-runtime/state/thread-sort";

const EMPTY_CONTENT_MATCH_KEYS: ReadonlySet<string> = new Set<string>();
Expand Down
Loading