Skip to content

feat(acp): connect registry providers to shared sign-in flows - #12967

Merged
juliusmarminge merged 15 commits into
t3code/codex-turn-mappingfrom
provider-auth/acp-registry
Sep 22, 2026
Merged

juliusmarminge merged 15 commits into
t3code/codex-turn-mappingfrom
provider-auth/acp-registry

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Registry-installed ACP providers need a consistent account setup path instead of requiring users to discover the correct CLI login command themselves.

Discover advertised authentication methods and connect them to the shared sign-in flow, including browser consent and interactive terminal login. Verify authentication with a fresh ACP session and refresh methods after runtime updates. Credentials remain in each agent's native store; credential changes coordinate all instances sharing that agent's binding.

Managed runtimes use tools/<agent-id>/<version>/ inside T3 home, including isolated npm and Python installs. Launch the registry version by default; existing PATH binaries require an explicit executable override. Mistral retry notifications update the existing retry UI, and structured ACP errors retain the provider's error message.

Depends on #12966.

Validation: 131 focused catalog, driver, authentication, adapter, and terminal tests passed for managed installs. Scoped server typecheck and targeted lint passed (one existing lint warning). A real managed Mistral binary returned version 2.25.5 through ACP initialize. Earlier integrated stack validation passed 231 focused tests.

Latest restacked validation: 219 focused ACP/Cursor backend tests and 63 provider-settings web tests pass. Scoped server and web typechecks pass.

Live ACP sign-in and before/after UI evidence are pending. The V2 selection-restart CI failure is tracked by #13113. This PR remains a draft.

Implemented with GPT-6 in the Codex harness.

@juliusmarminge
juliusmarminge added this pull request to stack #12968 September 22, 2026 00:40
@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Sep 22, 2026
@juliusmarminge juliusmarminge changed the title provider auth/acp registry feat(acp): connect registry providers to shared sign-in flows Sep 22, 2026
@github-actions github-actions Bot added the size:XL 500-999 changed lines (additions + deletions). label Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 4.9 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.4 KiB — 29.3 KiB ✅
Codex Live turn messages — 2 — 8 ✅
Claude Total thread wire — 4.9 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 20.7 KiB — 29.3 KiB ✅
Claude Live turn messages — 1 — 8 ✅

Baseline: unavailable · PR result: c4ba935 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 106.1 KiB
  • Claude decoded thread snapshot: 106.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge
juliusmarminge force-pushed the provider-auth/acp-registry branch from 6bc8dbc to c3a1c5d Compare September 22, 2026 01:01
@juliusmarminge
juliusmarminge force-pushed the provider-auth/acp-registry branch 2 times, most recently from 107da3d to ea880e0 Compare September 22, 2026 01:05
@juliusmarminge
juliusmarminge force-pushed the provider-auth/acp-registry branch from ea880e0 to 9d52328 Compare September 22, 2026 01:14
@juliusmarminge
juliusmarminge force-pushed the provider-auth/acp-registry branch from 9d52328 to 647baac Compare September 22, 2026 01:20
@juliusmarminge
juliusmarminge force-pushed the provider-auth/acp-registry branch 2 times, most recently from 3800e34 to 729b58a Compare September 22, 2026 01:23
@juliusmarminge
juliusmarminge force-pushed the provider-auth/acp-registry branch 2 times, most recently from fef3572 to df9d598 Compare September 22, 2026 01:30
@juliusmarminge
juliusmarminge force-pushed the provider-auth/acp-registry branch from df9d598 to f78a3f8 Compare September 22, 2026 01:34
@juliusmarminge
juliusmarminge force-pushed the provider-auth/acp-registry branch from f78a3f8 to 20e903c Compare September 22, 2026 01:39
@juliusmarminge
juliusmarminge force-pushed the provider-auth/acp-registry branch from 20e903c to 394c71e Compare September 22, 2026 01:41
Comment thread apps/server/src/provider/Drivers/AcpRegistryDriver.ts Outdated
@macroscopeapp

macroscopeapp Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Effect Service Conventions found one issue in apps/server/src/provider/Drivers/AcpRegistryDriver.ts: AcpRegistryAuth and AcpRegistryAuthenticationState are imported as named constructors rather than service-module namespaces. An inline review comment was posted with the expected fix.

Posted via Macroscope — Effect Service Conventions

@macroscopeapp

This comment has been minimized.

Base automatically changed from provider-auth/cursor to t3code/codex-turn-mapping September 22, 2026 23:43
juliusmarminge and others added 15 commits September 22, 2026 16:43
- Chat sessions again run agent-managed sign-in when the agent reports
  auth_required; only discovery and probes surface it without authenticating.
- Registry versions must look like versions, so "." or ".." cannot become
  an install directory segment.
- Path-overridden agents without a version rediscover sign-in methods on
  refresh instead of reusing the first result forever.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tool and plan progress for calls that started before the retry can arrive
mid-retry, so it no longer marks the retry as recovered.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…iver

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge force-pushed the provider-auth/acp-registry branch from 08353f9 to c4ba935 Compare September 22, 2026 23:43
Comment thread apps/server/src/provider/Drivers/AcpRegistryDriver.ts
@juliusmarminge
juliusmarminge merged commit a419382 into t3code/codex-turn-mapping Sep 22, 2026
24 checks passed
@juliusmarminge
juliusmarminge deleted the provider-auth/acp-registry branch September 22, 2026 23:50
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant