refactor(cursor): use shared provider account setup and storage - #12966
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
89d8cc4 to
ec94394
Compare
This comment has been minimized.
This comment has been minimized.
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR changes production authentication behavior and migrates Cursor credentials from a legacy file into shared secret-backed storage, while also changing the account-management UI and auth-state contract. Because it handles sensitive credentials and existing sign-in persistence, human review is required. Notes:
You can add or adjust custom eligibility rules. Learn more. |
986f614 to
dcbe30f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Effect Service Conventions found one blocking namespace-import violation; see the inline review comment. Posted via Macroscope — Effect Service Conventions |
Earlier versions kept Cursor credentials in <stateDir>/provider-auth/<instance>/cursor.json. Import that sign-in once when the secret store has none, then delete the file so the API key is not left on disk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sign-in The driver now takes the secret store from its environment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8b0a99a to
ccf168b
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Cursor browser login landed in #12948 with its own settings UI and credential persistence. Keeping that separate would duplicate the setup architecture for subsequent providers.
Adapt Cursor to the shared account contracts and settings UI, and persist its SDK credentials through the common provider credential store. Retain the SDK-specific login, verification, cancellation, and rollback behavior at the Cursor adapter boundary.
Depends on #12965.
Validation: focused Cursor authentication, credential persistence, driver, and provider tests passed, including damaged-store recovery. Scoped server and web typechecks passed.
Live Cursor sign-in and before/after UI evidence are pending. The V2 selection-restart CI failure is tracked by #13113. This PR remains a draft.
Implemented with GPT-6 in the Codex harness.