Skip to content

refactor(cursor): use shared provider account setup and storage - #12966

Merged
juliusmarminge merged 6 commits into
t3code/codex-turn-mappingfrom
provider-auth/cursor
Sep 22, 2026
Merged

juliusmarminge merged 6 commits into
t3code/codex-turn-mappingfrom
provider-auth/cursor

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Cursor browser login landed in #12948 with its own settings UI and credential persistence. Keeping that separate would duplicate the setup architecture for subsequent providers.

Adapt Cursor to the shared account contracts and settings UI, and persist its SDK credentials through the common provider credential store. Retain the SDK-specific login, verification, cancellation, and rollback behavior at the Cursor adapter boundary.

Depends on #12965.

Validation: focused Cursor authentication, credential persistence, driver, and provider tests passed, including damaged-store recovery. Scoped server and web typechecks passed.

Live Cursor sign-in and before/after UI evidence are pending. The V2 selection-restart CI failure is tracked by #13113. This PR remains a draft.

Implemented with GPT-6 in the Codex harness.

@juliusmarminge
juliusmarminge added this pull request to stack #12968 September 22, 2026 00:40
@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Sep 22, 2026
@juliusmarminge juliusmarminge changed the title provider auth/cursor refactor(cursor): use shared provider account setup and storage Sep 22, 2026
@github-actions github-actions Bot added the size:L 100-499 changed lines (additions + deletions). label Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 4.9 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.4 KiB — 29.3 KiB ✅
Codex Live turn messages — 2 — 8 ✅
Claude Total thread wire — 4.9 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 20.8 KiB — 29.3 KiB ✅
Claude Live turn messages — 2 — 8 ✅

Baseline: unavailable · PR result: ccf168b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 106.1 KiB
  • Claude decoded thread snapshot: 106.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge
juliusmarminge force-pushed the provider-auth/cursor branch 23 times, most recently from 89d8cc4 to ec94394 Compare September 22, 2026 20:35
@macroscopeapp

This comment has been minimized.

@macroscopeapp

macroscopeapp Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes production authentication behavior and migrates Cursor credentials from a legacy file into shared secret-backed storage, while also changing the account-management UI and auth-state contract. Because it handles sensitive credentials and existing sign-in persistence, human review is required.

Notes:

  • All code in this push has already been reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

Comment thread apps/server/src/provider/CursorCredentialStore.ts Outdated
@macroscopeapp

This comment has been minimized.

@macroscopeapp

This comment has been minimized.

@macroscopeapp

This comment has been minimized.

@macroscopeapp

This comment has been minimized.

@macroscopeapp

This comment has been minimized.

@macroscopeapp

This comment has been minimized.

@macroscopeapp

macroscopeapp Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Effect Service Conventions found one blocking namespace-import violation; see the inline review comment.

Posted via Macroscope — Effect Service Conventions

Base automatically changed from provider-auth/foundation to t3code/codex-turn-mapping September 22, 2026 23:35
juliusmarminge and others added 6 commits September 22, 2026 16:35
Earlier versions kept Cursor credentials in
<stateDir>/provider-auth/<instance>/cursor.json. Import that sign-in once
when the secret store has none, then delete the file so the API key is not
left on disk.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sign-in

The driver now takes the secret store from its environment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@macroscopeapp

This comment has been minimized.

@juliusmarminge
juliusmarminge merged commit c1a96cb into t3code/codex-turn-mapping Sep 22, 2026
24 checks passed
@juliusmarminge
juliusmarminge deleted the provider-auth/cursor branch September 22, 2026 23:43
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 24, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant