Conversation
The upstream sync desktop artifact build rejected the workspace configuration because msgpackr-extract was set to a prose placeholder instead of a boolean. Restore the intended true value so the build can read the workspace config and package the desktop artifact.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This one-line configuration fix restores the native build permission for You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe workspace configuration changes ChangesWorkspace build configuration
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to The configuration fix enables the intended desktop artifact build without an identified residual merge risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Upstream pingdotgg#12326 left the prose placeholder "set this to true or false" for allowBuilds.msgpackr-extract, and the desktop artifact script rejects any non-boolean value, so the build fails before packaging. Restores the previous true value. Carried from open upstream PR pingdotgg#12435 (fixes pingdotgg#12434). Drop this commit when that PR lands. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The Effect rc.115 bump committed pnpm's placeholder text for msgpackr-extract in allowBuilds, which the desktop artifact build rejects because it decodes allowBuilds as booleans. Restore the previous value. Same change as upstream PR pingdotgg#12435.
|
Superseded by #12544, which dropped the placeholder |
Fixes #12434
The upstream sync flow reinstalls dependencies and then builds the desktop artifact. That build failed before packaging because
pnpm-workspace.yamlused the prose placeholderset this to true or falseforallowBuilds.msgpackr-extract, while the build script requires a boolean workspace configuration.Restore the intended
truevalue. The exact macOS ZIP artifact command now completes successfully and produces the arm64 ZIP.Verification:
T3CODE_DESKTOP_PLATFORM=mac T3CODE_DESKTOP_TARGET=zip T3CODE_DESKTOP_OUTPUT_DIR=<temporary directory> pnpm run dist:desktop:artifact— passedcorepack pnpm exec vp run --filter @t3tools/desktop typecheck— passedcorepack pnpm exec vp fmt --check pnpm-workspace.yaml— passedThis is a configuration-only fix; no UI screenshots are applicable.
Summary by CodeRabbit