Skip to content

fix(build): restore msgpackr build permission - #12435

Closed
Brechard wants to merge 1 commit into
pingdotgg:mainfrom
Brechard:fix/msgpackr-build-permission
Closed

Brechard wants to merge 1 commit into
pingdotgg:mainfrom
Brechard:fix/msgpackr-build-permission

Conversation

@Brechard

@Brechard Brechard commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #12434

The upstream sync flow reinstalls dependencies and then builds the desktop artifact. That build failed before packaging because pnpm-workspace.yaml used the prose placeholder set this to true or false for allowBuilds.msgpackr-extract, while the build script requires a boolean workspace configuration.

Restore the intended true value. The exact macOS ZIP artifact command now completes successfully and produces the arm64 ZIP.

Verification:

  • T3CODE_DESKTOP_PLATFORM=mac T3CODE_DESKTOP_TARGET=zip T3CODE_DESKTOP_OUTPUT_DIR=<temporary directory> pnpm run dist:desktop:artifact — passed
  • corepack pnpm exec vp run --filter @t3tools/desktop typecheck — passed
  • corepack pnpm exec vp fmt --check pnpm-workspace.yaml — passed
  • Focused artifact test: 70 passed, 1 existing unrelated upstream failure in the cross-architecture Windows native-probe test

This is a configuration-only fix; no UI screenshots are applicable.

Summary by CodeRabbit

  • Chores
    • Updated build configuration to explicitly allow the required package build step.

The upstream sync desktop artifact build rejected the workspace configuration because msgpackr-extract was set to a prose placeholder instead of a boolean. Restore the intended true value so the build can read the workspace config and package the desktop artifact.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 18, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at e123fbc

Macroscope's review found this PR approvable — This one-line configuration fix restores the native build permission for msgpackr-extract, which is needed when preparing packaged runtime artifacts. It does not change product behavior, APIs, or static-analysis settings.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 98067cbd-1f3f-4ed5-8014-23308ab61a13

📥 Commits

Reviewing files that changed from the base of the PR and between 52e4b44 and e123fbc.

📒 Files selected for processing (1)
  • pnpm-workspace.yaml

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The workspace configuration changes msgpackr-extract from a placeholder string to the boolean value true under allowBuilds.

Changes

Workspace build configuration

Layer / File(s) Summary
Set msgpackr-extract build permission
pnpm-workspace.yaml
The allowBuilds.msgpackr-extract value is now true, matching the workspace schema.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to e123f

The configuration fix enables the intended desktop artifact build without an identified residual merge risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the configuration fix and the restored msgpackr build permission. It is concise and directly related to the main change.
Description check ✅ Passed The description clearly explains what changed, why the change was needed, the verification performed, and why UI evidence is not applicable. It does not use the template headings or checklist, but it …
Linked Issues check ✅ Passed The change updates pnpm-workspace.yaml so allowBuilds.msgpackr-extract is true instead of the prose placeholder. This satisfies issue #12434 because the value is now a boolean accepted by the wo…
Out of Scope Changes check ✅ Passed The reported change is limited to the msgpackr-extract workspace configuration required by issue #12434. The summary reports no public API changes and no unrelated file changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

sandscooling pushed a commit to sandscooling/t3code that referenced this pull request Sep 18, 2026
Upstream pingdotgg#12326 left the prose placeholder "set this to true or false"
for allowBuilds.msgpackr-extract, and the desktop artifact script rejects
any non-boolean value, so the build fails before packaging. Restores the
previous true value.

Carried from open upstream PR pingdotgg#12435 (fixes pingdotgg#12434). Drop this commit
when that PR lands.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
AhmedShareef added a commit to AhmedShareef/t3code that referenced this pull request Sep 18, 2026
The Effect rc.115 bump committed pnpm's placeholder text for
msgpackr-extract in allowBuilds, which the desktop artifact build
rejects because it decodes allowBuilds as booleans. Restore the
previous value. Same change as upstream PR pingdotgg#12435.
@juliusmarminge

Copy link
Copy Markdown
Member

Superseded by #12544, which dropped the placeholder allowBuilds.msgpackr-extract entry on main (same failure mode; alternative approach was setting it to true).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop artifact build rejects msgpackr-extract allowBuilds value

3 participants