Skip to content

fix(web): normalize disabled control opacity - #11441

Merged
maria-rcks merged 2 commits into
mainfrom
fix/disabled-opacity-consistency
Sep 24, 2026
Merged

maria-rcks merged 2 commits into
mainfrom
fix/disabled-opacity-consistency

Conversation

@t3-code

@t3-code t3-code Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

summary

normalize disabled opacity to 64% across composer actions, terminal split-limit actions, settings rows, unavailable provider/git choices, discovery rows, and both sidebar menu/submenu disabled and aria-disabled states.

merged current main d5d48742. preserved its composer shadow utilities and container-responsive settings layout. diagnostics now use the upstream shared ProcessSignalActions / InlineButton, which already supplies 64% opacity; the old diagnostic implementations and screenshots are no longer part of this change. the timeline remains unchanged because its dimming marks collapsed, interactive content.

verification

  • web typecheck, targeted lint, targeted formatting, and diff checks passed.
  • merge commit hook attempted formatting thousands of upstream files and failed through resource exhaustion/timeouts. bypassed that hook for this merge after the scoped checks passed.
  • refreshed all current before/after crops against main d5d48742 and resolved head 4e2d3e85.
  • 14 pairs cover all 12 changed lines, with native and aria-disabled sidebar states separately shown. provider grids include all current choices.
  • exact-source JSX/component previews in chromium with the app stylesheet, fixed disabled/unavailable inputs, inert handlers, and sample shared-row labels. these are not full-page or backend-interaction tests.
  • every changed control computed to its original 30%, 45%, 50%, or 55% before and 64% after. all 28 images have equal pair dimensions and verified pixel differences.

cropped before/after

primary composer

before

primary composer, before

after

primary composer, after

collapsed composer

before

collapsed composer, before

after

collapsed composer, after

floating terminal horizontal split

before

floating terminal horizontal split, before

after

floating terminal horizontal split, after

floating terminal vertical split

before

floating terminal vertical split, before

after

floating terminal vertical split, after

sidebar terminal horizontal split

before

sidebar terminal horizontal split, before

after

sidebar terminal horizontal split, after

sidebar terminal vertical split

before

sidebar terminal vertical split, before

after

sidebar terminal vertical split, after

sidebar menu disabled

before

sidebar menu disabled, before

after

sidebar menu disabled, after

sidebar menu aria-disabled

before

sidebar menu aria-disabled, before

after

sidebar menu aria-disabled, after

sidebar submenu disabled

before

sidebar submenu disabled, before

after

sidebar submenu disabled, after

sidebar submenu aria-disabled

before

sidebar submenu aria-disabled, before

after

sidebar submenu aria-disabled, after

settings row aria-disabled

before

settings row aria-disabled, before

after

settings row aria-disabled, after

discovery row disabled

before

discovery row disabled, before

after

discovery row disabled, after

coming-soon provider choices

before

coming-soon provider choices, before

after

coming-soon provider choices, after

unavailable git provider choices

before

unavailable git provider choices, before

after

unavailable git provider choices, after

request provenance

requested by @UtkarshUsername.

model: gpt-6-astra. harness: hermes agent.

Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>
@cursor

cursor Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 12, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes the default disabled-state opacity across eight production UI components, affecting composer, terminal, settings, provider, discovery, and sidebar controls. The implementation is limited to visual classes, but the broad product-default presentation change warrants human review.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.5 KiB 13.5 KiB −1 B (−0.0%) 15.1 KiB ✅
Codex Thread snapshot wire 7.0 KiB 7.1 KiB +18 B (+0.2%) 7.3 KiB ✅
Codex Live turn WebSocket wire 6.5 KiB 6.5 KiB −19 B (−0.3%) 7.8 KiB ✅
Codex Live turn WebSocket decoded 56.3 KiB 56.3 KiB 0 B (0.0%) 66.4 KiB ✅
Codex Live turn messages 10 10 0 (0.0%) 21 ✅
Claude Total thread wire 13.5 KiB 13.5 KiB 0 B (0.0%) 15.1 KiB ✅
Claude Thread snapshot wire 7.1 KiB 7.1 KiB +16 B (+0.2%) 7.3 KiB ✅
Claude Live turn WebSocket wire 6.5 KiB 6.4 KiB −16 B (−0.2%) 7.8 KiB ✅
Claude Live turn WebSocket decoded 57.1 KiB 57.0 KiB −44 B (−0.1%) 66.4 KiB ✅
Claude Live turn messages 10 9 −1 (−10.0%) 21 ✅

Baseline: d5d4874 · PR result: 4e2d3e8 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 114.0 KiB
  • Claude decoded thread snapshot: 114.7 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>
@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Sep 24, 2026
@maria-rcks
maria-rcks merged commit 720490a into main Sep 24, 2026
23 checks passed
@maria-rcks
maria-rcks deleted the fix/disabled-opacity-consistency branch September 24, 2026 22:19
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 25, 2026
## What's Changed
* lint/unknown and static by @juliusmarminge in pingdotgg/t3code#13366
* fix(web): web colors come from theme tokens by @juliusmarminge in pingdotgg/t3code#13371
* fix(web): appearance classes use theme tokens and scale values by @juliusmarminge in pingdotgg/t3code#13397
* fix(server): keep Codex's reset answer when the re-probe fails by @juliusmarminge in pingdotgg/t3code#13363
* fix(mobile): branch search finds remote and space-typed branches by @Bil0000 in pingdotgg/t3code#13454
* chore(ci): use GPT 6 Sol Max for check agents by @juliusmarminge in pingdotgg/t3code#13473
* feat(server): show and redeem Claude banked resets by @Bil0000 in pingdotgg/t3code#13118
* fix(observability): a malformed OTEL_RESOURCE_ATTRIBUTES no longer stops startup by @yordis in pingdotgg/t3code#13469
* fix(antigravity): let Stop end commands that outlived their turn by @juliusmarminge in pingdotgg/t3code#13388
* fix(web,mobile): drop the baked-in tile from the Antigravity icon by @flamboh in pingdotgg/t3code#13373
* fix(marketing): use the official OpenCode and Antigravity logos by @flamboh in pingdotgg/t3code#13365
* fix(acp): keep one answer when a running tool reports progress by @juliusmarminge in pingdotgg/t3code#13386
* feat(web): run shell commands from chat in the thread terminal by @Bil0000 in pingdotgg/t3code#13060
* fix(antigravity): keep Windows runtime unpacking under MAX_PATH by @juliusmarminge in pingdotgg/t3code#13389
* fix(codex): the protocol generator runs again on Effect rc.115 by @juliusmarminge in pingdotgg/t3code#13480
* feat(codex): require Codex 0.156 and regenerate its protocol by @juliusmarminge in pingdotgg/t3code#13481
* feat(threads): add per-thread auto-settle switch by @t3dotgg in pingdotgg/t3code#11846
* fix(web): working and monitoring threads fade in the sidebar again by @t3dotgg in pingdotgg/t3code#13506
* fix(server): streamed section titles wait for the text under them by @t3dotgg in pingdotgg/t3code#13504
* fix(web): normalize disabled control opacity by @t3-code[bot] in pingdotgg/t3code#11441


**Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260924.2213...v0.0.43-nightly.20260924.2223

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260924.2223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant