fix(mobile): fold subagent lifecycle rows into one batch per spawn - #10211
Conversation
Each subagent's progress and completion rendered as its own timeline row on mobile, while web folds a turn's spawns into one "Kicked off N subagents" row. Use the same spawn-group keys as web's session-logic, keep the batch anchored where the run launched, derive its lifecycle from the members, and list the members with their states when the row is opened. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR changes the existing mobile work-log behavior by replacing individual agent lifecycle rows with stateful batches across direct spawns and workflows. The implementation spans filtering, aggregation, lifecycle derivation, and expanded rendering, making the change broader than a straightforward isolated fix. You can add or adjust custom eligibility rules. Learn more. |
Bypassed workflow member rows were dropped before batching, so a workflow batch only ever held its coordinator, and a Codex child's idle turn end left the batch working forever. Let agent lifecycle rows through the internal filter the way web does, treat idle as a finished member, and settle members that never reported their own end when the coordinator finishes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
When the PR selected for `early` does not apply at the reconciled upstream boundary, the command stopped with a single line that gave nothing to act on: ```console $ node scripts/upstream-queue.ts early 11784 --through upstream/main Selected pingdotgg#11784 cannot be applied at the upstream boundary. ``` That happens when the PR builds on upstream work the fork has not taken in yet, and the planner only looks for dependencies in the changes it replays after a successful apply. The command now reports which of the PR's files conflict at the boundary and which earlier pending upstream PRs and direct commits change those files, in upstream order. Text output lists the first 20 and says how many remain; `--json` includes every source with its SHA, PR, and title. A plan that succeeds prints as before. The intake runbook's `early` paragraph describes the report. ## Validation - A new test in `scripts/upstream-early.test.ts` checks which sources the report lists: pending sources after the boundary and before the blocked PR whose files overlap the conflicting paths, including direct commits and directory prefixes, and not recorded or later sources. - `scripts/upstream-early.test.ts` and `scripts/upstream-queue.test.ts` pass (21 tests); lint, formatting, and the scripts typecheck are clean. - Against fetched fork `main` (`495b7cfd5`) and upstream `main` (`b2b43bef7`), the same command now prints: ```console $ node scripts/upstream-queue.ts early 11784 --through upstream/main Fork 495b7cf; reconciled through d28077e pingdotgg#11784 does not apply at the reconciled boundary. 16 of its files conflict there: apps/mobile/src/features/threads/ThreadFeed.tsx apps/mobile/src/features/threads/thread-work-log.tsx apps/mobile/src/lib/threadActivity.ts apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.ts apps/server/src/orchestration/decider.ts apps/server/src/provider/Layers/ClaudeAdapter.test.ts apps/server/src/provider/Layers/ClaudeAdapter.ts apps/server/src/textGeneration/ThreadTitleContext.test.ts apps/server/src/textGeneration/ThreadTitleContext.ts apps/server/src/ws.ts apps/web/src/components/chat/MessagesTimeline.logic.ts apps/web/src/components/chat/MessagesTimeline.tsx apps/web/src/components/settings/SettingsPanels.tsx packages/client-runtime/src/state/environmentHttpAuth.test.ts packages/client-runtime/src/state/threadSnapshotHttp.ts packages/contracts/src/orchestration.ts Earlier pending upstream changes to those files: 110 PRs. Take them in first, or add their PRs to this plan. pingdotgg#9594 fix(connect): refresh HTTP credentials without reconnecting (pingdotgg#9594) pingdotgg#9894 fix(chat): show hours for long runs (pingdotgg#9894) pingdotgg#9933 fix(settings): share restart continuation across environments (pingdotgg#9933) pingdotgg#10092 fix(web): scale agent spawn rows with interface font (pingdotgg#10092) pingdotgg#9965 fix(web): keep the composer expanded until the thread can scroll (pingdotgg#9965) pingdotgg#9935 fix(web): align tool disclosure chevrons with expanded state (pingdotgg#9935) pingdotgg#10199 fix(mobile): size a chat image's frame before its bytes arrive (pingdotgg#10199) pingdotgg#10200 fix(web): size the chat image slot from server-reported dimensions (pingdotgg#10200) pingdotgg#10167 refactor(client-runtime): remove unused runtime exports and helpers (pingdotgg#10167) pingdotgg#10173 fix(mobile): restore live tool shimmer and add a Thinking row (pingdotgg#10173) pingdotgg#10210 fix(mobile): only make work rows expandable when the body adds something (pingdotgg#10210) pingdotgg#10211 fix(mobile): fold subagent lifecycle rows into one batch per spawn (pingdotgg#10211) pingdotgg#10212 fix(mobile): stop clipping expanded tool groups (pingdotgg#10212) pingdotgg#9875 feat: show provider usage limits with /usage-limits (pingdotgg#9875) pingdotgg#9561 fix(ui): unify loading and refresh feedback across clients (pingdotgg#9561) pingdotgg#10226 refactor(web): keep feature component helpers private (pingdotgg#10226) pingdotgg#9754 feat(settings): add shared project defaults and scoped overrides (pingdotgg#9754) pingdotgg#9895 feat(connections): balance new threads across connected machines (pingdotgg#9895) pingdotgg#10273 fix(mobile): stop the work log flickering during subagent runs and failing calls (pingdotgg#10273) pingdotgg#10271 fix(mobile): save linked media from chat (pingdotgg#10271) ... 90 more; --json lists every source. ``` `--json` returns the same 16 paths and all 110 sources. `early 5521 --through upstream/main`, which plans successfully, prints the same summary as before. --- Written by an agent (Claude Code, claude-opus-5-5).
Stacked on #10210.
Problem
Each subagent's progress and completion rendered as its own timeline row on mobile (three agents → three "Running …" rows plus their completions), while web folds a turn's spawns into one "Kicked off N subagents" row via
collapseDerivedWorkLogEntriesinsession-logic.ts.Fix
Mirror web's batching in the mobile work log:
wf:<coordinator>for workflows,direct:<turn>for direct spawns), decided at the first row seen pertaskIdso later rows under synthetic turns cannot splinter the batch.agentKind !== "agent") keep one row per task, as before.idleturn end counts as finished, and a finished coordinator settles members that never reported their own end. That lifecycle feeds the group summary and shimmer from fix(mobile): restore live tool shimmer and add a Thinking row #10173 unchanged.Verification
vp test run apps/mobile/src/lib/threadActivity.test.ts— 98 passed, including new tests that fold two direct spawns into one row and track it through running → one done → one failed, fold bypassed workflow members into the coordinator's batch and settle them with it, and finish a Codex child onidle; plus updated expectations for the resumed-agent and Antigravity batch cases.tsc --noEmitforapps/mobile, targeted lint and format.mainand this branch.Implemented by Claude Fable 5 in the Claude Code harness.
Note
Fold subagent lifecycle rows into one batch row per spawn in mobile
threadActivityisAgentInternalActivitynow retains agent task rows with task IDs (including bypassed rows) for batch folding instead of filtering them; consumers ofcollapseDerivedWorkLogEntrieswill see fewer rows and new structured spawn metadata onWorkLogEntry.Macroscope summarized a83379d.