Skip to content

refactor(client-runtime): remove unused runtime exports and helpers - #10167

Merged
juliusmarminge merged 6 commits into
cleanup-packages/shared-internalsfrom
cleanup-packages/client-internals
Sep 5, 2026
Merged

juliusmarminge merged 6 commits into
cleanup-packages/shared-internalsfrom
cleanup-packages/client-internals

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 5, 2026 •

Copy link
Copy Markdown
Member

Client runtime exposes unused helpers and layer wrappers through its internal package API.

Remove unused runtime helpers/wrappers and redundant runtime re-exports. Preserve exported types, schema values, and live web re-exports. Keep the unused vcsStatus module deletion because whole-file checks remain enforced; its stale re-export is removed with it. Retain service constructors and the non-schema error exports needed by consumers' inferred return types.

Verification: client-runtime and web typechecks pass. Existing client-runtime and affected web tests pass on the rebased stack, including the sidebar ordering and VCS suites. No existing tests were changed or removed.

Follows #10166.

Model: gpt-6 astra. Harness: Codex in T3 Code.

@cursor

cursor Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 13.5 KiB — 15.1 KiB ✅
Codex Thread snapshot wire — 7.0 KiB — 7.3 KiB ✅
Codex Live turn WebSocket wire — 6.5 KiB — 7.8 KiB ✅
Codex Live turn WebSocket decoded — 57.0 KiB — 66.4 KiB ✅
Codex Live turn messages — 8 — 21 ✅
Claude Total thread wire — 13.5 KiB — 15.1 KiB ✅
Claude Thread snapshot wire — 7.0 KiB — 7.3 KiB ✅
Claude Live turn WebSocket wire — 6.5 KiB — 7.8 KiB ✅
Claude Live turn WebSocket decoded — 57.8 KiB — 66.4 KiB ✅
Claude Live turn messages — 8 — 21 ✅

Baseline: unavailable · PR result: 1de8906 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 5, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR primarily removes unused runtime exports and helper layers without changing active implementations or product defaults. It also modifies the client-runtime authorization package, which is a sensitive area requiring human review under the approvability criteria.

Notes:

  • Diff unchanged. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@cursor

cursor Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@macroscopeapp
macroscopeapp Bot dismissed their stale review September 5, 2026 16:58

Dismissing prior approval to re-evaluate cb5b515

@juliusmarminge
juliusmarminge force-pushed the cleanup-packages/client-internals branch from 2cb5a95 to c545923 Compare September 5, 2026 17:04
@juliusmarminge
juliusmarminge force-pushed the cleanup-packages/client-internals branch from c545923 to a0f41e8 Compare September 5, 2026 17:18
@juliusmarminge
juliusmarminge force-pushed the cleanup-packages/client-internals branch from a0f41e8 to 852f895 Compare September 5, 2026 18:24
@juliusmarminge juliusmarminge changed the title refactor(client-runtime): remove unused package exports and helpers refactor(client-runtime): remove unused runtime exports and helpers Sep 5, 2026
@juliusmarminge
juliusmarminge force-pushed the cleanup-packages/client-internals branch from 852f895 to 1de8906 Compare September 5, 2026 18:29
@juliusmarminge
juliusmarminge merged commit dbfd517 into main Sep 5, 2026
33 of 45 checks passed
@juliusmarminge
juliusmarminge deleted the cleanup-packages/client-internals branch September 5, 2026 22:55
incognitojam added a commit to incognitojam/styal that referenced this pull request Sep 24, 2026
When the PR selected for `early` does not apply at the reconciled
upstream boundary, the command stopped with a single line that gave
nothing to act on:

```console
$ node scripts/upstream-queue.ts early 11784 --through upstream/main
Selected pingdotgg#11784 cannot be applied at the upstream boundary.
```

That happens when the PR builds on upstream work the fork has not taken
in yet, and the planner only looks for dependencies in the changes it
replays after a successful apply.

The command now reports which of the PR's files conflict at the boundary
and which earlier pending upstream PRs and direct commits change those
files, in upstream order. Text output lists the first 20 and says how
many remain; `--json` includes every source with its SHA, PR, and title.
A plan that succeeds prints as before. The intake runbook's `early`
paragraph describes the report.

## Validation

- A new test in `scripts/upstream-early.test.ts` checks which sources
the report lists: pending sources after the boundary and before the
blocked PR whose files overlap the conflicting paths, including direct
commits and directory prefixes, and not recorded or later sources.
- `scripts/upstream-early.test.ts` and `scripts/upstream-queue.test.ts`
pass (21 tests); lint, formatting, and the scripts typecheck are clean.
- Against fetched fork `main` (`495b7cfd5`) and upstream `main`
(`b2b43bef7`), the same command now prints:

  ```console
  $ node scripts/upstream-queue.ts early 11784 --through upstream/main
  Fork 495b7cf; reconciled through d28077e
pingdotgg#11784 does not apply at the reconciled boundary. 16 of its files
conflict there:
    apps/mobile/src/features/threads/ThreadFeed.tsx
    apps/mobile/src/features/threads/thread-work-log.tsx
    apps/mobile/src/lib/threadActivity.ts
    apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.ts
    apps/server/src/orchestration/decider.ts
    apps/server/src/provider/Layers/ClaudeAdapter.test.ts
    apps/server/src/provider/Layers/ClaudeAdapter.ts
    apps/server/src/textGeneration/ThreadTitleContext.test.ts
    apps/server/src/textGeneration/ThreadTitleContext.ts
    apps/server/src/ws.ts
    apps/web/src/components/chat/MessagesTimeline.logic.ts
    apps/web/src/components/chat/MessagesTimeline.tsx
    apps/web/src/components/settings/SettingsPanels.tsx
    packages/client-runtime/src/state/environmentHttpAuth.test.ts
    packages/client-runtime/src/state/threadSnapshotHttp.ts
    packages/contracts/src/orchestration.ts
Earlier pending upstream changes to those files: 110 PRs. Take them in
first, or add their PRs to this plan.
pingdotgg#9594 fix(connect): refresh HTTP credentials without reconnecting
(pingdotgg#9594)
    pingdotgg#9894 fix(chat): show hours for long runs (pingdotgg#9894)
pingdotgg#9933 fix(settings): share restart continuation across environments
(pingdotgg#9933)
    pingdotgg#10092 fix(web): scale agent spawn rows with interface font (pingdotgg#10092)
pingdotgg#9965 fix(web): keep the composer expanded until the thread can scroll
(pingdotgg#9965)
pingdotgg#9935 fix(web): align tool disclosure chevrons with expanded state
(pingdotgg#9935)
pingdotgg#10199 fix(mobile): size a chat image's frame before its bytes arrive
(pingdotgg#10199)
pingdotgg#10200 fix(web): size the chat image slot from server-reported
dimensions (pingdotgg#10200)
pingdotgg#10167 refactor(client-runtime): remove unused runtime exports and
helpers (pingdotgg#10167)
pingdotgg#10173 fix(mobile): restore live tool shimmer and add a Thinking row
(pingdotgg#10173)
pingdotgg#10210 fix(mobile): only make work rows expandable when the body adds
something (pingdotgg#10210)
pingdotgg#10211 fix(mobile): fold subagent lifecycle rows into one batch per
spawn (pingdotgg#10211)
    pingdotgg#10212 fix(mobile): stop clipping expanded tool groups (pingdotgg#10212)
    pingdotgg#9875 feat: show provider usage limits with /usage-limits (pingdotgg#9875)
pingdotgg#9561 fix(ui): unify loading and refresh feedback across clients (pingdotgg#9561)
pingdotgg#10226 refactor(web): keep feature component helpers private (pingdotgg#10226)
pingdotgg#9754 feat(settings): add shared project defaults and scoped overrides
(pingdotgg#9754)
pingdotgg#9895 feat(connections): balance new threads across connected machines
(pingdotgg#9895)
pingdotgg#10273 fix(mobile): stop the work log flickering during subagent runs
and failing calls (pingdotgg#10273)
    pingdotgg#10271 fix(mobile): save linked media from chat (pingdotgg#10271)
    ... 90 more; --json lists every source.
  ```

`--json` returns the same 16 paths and all 110 sources. `early 5521
--through upstream/main`, which plans successfully, prints the same
summary as before.

---
Written by an agent (Claude Code, claude-opus-5-5).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant