Remove php_error_docref_unchecked - #23042
Merged
Merged
Conversation
NattyNarwhal
force-pushed
the
remove-docref-unchecked
branch
from
August 4, 2026 16:50
ba4358c to
c866d1c
Compare
Member
|
The CI failure is fixed. You can rebase this to master to pass CI |
DanielEScherzer
approved these changes
Aug 4, 2026
After phpGH-22390 was merged, we can now use a %pS format specifier for zend_string without having to use the unchecked variant (so that gcc et al doesn't complain that %S should be for wchar_t*).
There are no external users AFAIK, and now no internal users.
NattyNarwhal
force-pushed
the
remove-docref-unchecked
branch
from
August 4, 2026 19:15
c866d1c to
6147e7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up GH-22930, this is some low hanging fruit (there's a lot more
zend_error_uncheckedandphp_printf_unchecked).