Fix GH-20404: crash when modifying weak references during destruction - #22390
Open
khaledalam wants to merge 1 commit into
Open
Fix GH-20404: crash when modifying weak references during destruction#22390khaledalam wants to merge 1 commit into
khaledalam wants to merge 1 commit into
Conversation
khaledalam
force-pushed
the
fix-gh20404-weakmap-dtor-reentrancy
branch
from
June 24, 2026 21:30
2b5f094 to
6810d12
Compare
NattyNarwhal
added a commit
to NattyNarwhal/php-src
that referenced
this pull request
Aug 4, 2026
After phpGH-22390 was merged, we can now use a %pS format specifier for zend_string without having to use the unchecked variant (so that gcc et al doesn't complain that %S should be for wchar_t*).
NattyNarwhal
added a commit
that referenced
this pull request
Aug 4, 2026
* standard: remove sole user of php_error_docref_unchecked After GH-22390 was merged, we can now use a %pS format specifier for zend_string without having to use the unchecked variant (so that gcc et al doesn't complain that %S should be for wchar_t*). * main: Remove php_error_docref_unchecked There are no external users AFAIK, and now no internal users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-20404.
zend_weakrefs_notify()cleared weak references by iterating EG(weakrefs) in place. Clearing an entry can run a user destructor that reentrantly registers (grows/reallocates the HT mid-iteration → UAF) or unregisters pending entries.Reworked to pop one entry at a time, never holding a cursor across user code. Handles both the new-registration crash and the existing nested-WeakMap unregistration path.