Skip to content

Give Windows its own platform crate rather than the unix one #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pathscale merged 1 commit into from
Sep 11, 2026
Merged

Give Windows its own platform crate rather than the unix one #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,17 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.0.14]

### Fixed

- Windows builds without `std` no longer fail to compile. `concurrent` named
`ps-reclaim/libc` in a feature list, and a feature list is not per target, so
Windows was handed the unix platform crate and never enabled its own. The
choice moves into `cfg(unix)` and `cfg(windows)` dependency sections. Builds
with `std` were unaffected, which is why this went unnoticed: `ps-reclaim`
only reaches for `windows-sys` on its `no_std` path.

## [0.0.12]

### Changed
Expand Down
16 changes: 13 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "WorkTablesIndex"
version = "0.0.13"
version = "0.0.14"
edition = "2021"
documentation = "https://docs.rs/WorkTablesIndex/"
repository = "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/pathscale/WorkTablesIndex"
Expand Down Expand Up @@ -55,7 +55,6 @@ parking_lot = { package = "parking_lot_lite_hack", version = "0.12.6", default-f
"send_guard",
"arc_lock",
], optional = true }
ps-reclaim = { version = "0.1.4", optional = true, default-features = false }
fastrand = { version = "2", optional = true, default-features = false }
superslice = { version = "1", optional = true }
wt-slice = { version = "0.1", optional = true }
Expand All @@ -70,7 +69,6 @@ serde = ["dep:serde", "ftree/serde", "std"]
concurrent = [
"dep:parking_lot",
"dep:ps-reclaim",
"ps-reclaim/libc",
"ps-reclaim/spin",
]
cdc = ["concurrent"]
Expand Down Expand Up @@ -143,3 +141,15 @@ while_let_loop = "allow"
[[bench]]
name = "locks"
harness = false

[target."cfg(unix)".dependencies.ps-reclaim]
version = "^0.1, >=0.1.4"
features = ["libc"]
optional = true
default-features = false

[target."cfg(windows)".dependencies.ps-reclaim]
version = "^0.1, >=0.1.4"
features = ["windows-sys"]
optional = true
default-features = false
Loading