Give Windows its own platform crate rather than the unix one - #19
Merged
Merged
Conversation
`concurrent` enabled `ps-reclaim/libc`, and a feature list is not per target, so every target got the unix platform crate and Windows never got `windows-sys`. The choice belongs in `cfg(unix)` and `cfg(windows)` dependency sections, which is where arctic-wt#10 put the same mistake. It only bites without `std`: `ps-reclaim` reaches for `windows-sys` solely on its `no_std` thread-local path, so the default build was fine and this stayed invisible. That path is the one this crate advertises, its own feature comment saying `std` is meant to be turned off. Checked as a library for x86_64-pc-windows-gnu, x86_64-unknown-linux-gnu and aarch64-unknown-linux-musl, with and without `std`. 110 tests pass on the host. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkTablesIndex 0.0.14 selects ps-reclaim's platform dependency by target: libc on Unix and windows-sys on Windows. Previously
concurrentunconditionally enabled libc, leaving Windows builds without the dependency needed by the no_std thread-local implementation.The change is confined to dependency feature selection and the release version. Tree algorithms and concurrency behavior are unchanged. DataBucket 0.7 and WorkTable 1.9.0-alpha1 require this version for the coordinated release.
Release review validation: host library/tests with all features, package Clippy across all targets and features with warnings denied, publication dry run, and Windows GNU x64 library checking with defaults disabled and concurrent/cdc/multimap enabled passed. Publish 0.0.14 before DataBucket 0.7.