Conversation
added 2 commits
September 13, 2026 20:57
Fourth agent, ACP JSON-RPC, no new crates. Steer is _x.ai/interject. Interrupt is session/cancel. Auto is native permission-mode auto. /compact maps; /clear is refused.
The ACP transport has no TUI, so `enter_plan_mode` and `exit_plan_mode` hang until the host's liveness ping aborts the turn (session 01a09bd5). Pass `--no-plan` so the model writes plans as ordinary assistant text. Also carries `used_percent` on `RateLimit`: Grok reports weekly window fill through `x.ai/session/usage`, which Claude's in-run rate limit object does not have. Defaulted to None everywhere else, so no provider changes shape.
Owner
Author
|
Consolidated into #35, which is the same Grok feature branch. Cherry-picked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Grok over the ACP transport, with two fixes the transport forces.
--no-plan. ACP has no TUI, soenter_plan_mode/exit_plan_modenever get an answer. The turn hangs until the host's liveness ping aborts it (session 01a09bd5). With the flag the model writes plans as ordinary assistant text.RateLimit::used_percent. Grok reports weekly window fill throughx.ai/session/usage. Claude's in-run rate-limit object has no equivalent, so the field isOption<f64>, defaulted toNoneeverywhere else and skipped when serializing. No other provider changes shape.Why it matters here
AgencyZero needs both to drive Grok as a project agent. That work is in pathscale/agencyzero and depends on this.
Testing
cargo test --lib: 228 passed, 0 failed.The
livesuite probes installed CLIs. Three tests fail on this machine and all three are environmental, not code:installed_agents_match_the_versions_the_flags_were_verified_againstandthe_codex_catalogue_still_matches_what_codex_reportsfail on master too (Codex drifted from the pinned catalogue).installed_agents_report_their_login_statepasses when run alone (grok: logged in as grok.com, defaultgrok-4.6); it only fails under parallel execution against real CLIs.