feat: Grok over grok agent stdio - #35
Merged
Merged
Conversation
added 3 commits
September 13, 2026 20:57
Fourth agent, ACP JSON-RPC, no new crates. Steer is _x.ai/interject. Interrupt is session/cancel. Auto is native permission-mode auto. /compact maps; /clear is refused.
The ACP transport has no TUI, so `enter_plan_mode` and `exit_plan_mode` hang until the host's liveness ping aborts the turn (session 01a09bd5). Pass `--no-plan` so the model writes plans as ordinary assistant text. Also carries `used_percent` on `RateLimit`: Grok reports weekly window fill through `x.ai/session/usage`, which Claude's in-run rate limit object does not have. Defaulted to None everywhere else, so no provider changes shape.
CI runs `cargo clippy --all-targets -- -D warnings`, which the new ACP module did not pass: numeric separators, `map(..).unwrap_or(..)` on a Result, the bool count on `Protocol`, and the JSON number casts. The casts are allowed rather than rewritten. Token counts and tick values are whole and far below 2^53, and the one narrowing cast is already guarded non-negative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Agent::Grokas a fourth backend. Transport isgrok agent stdio(ACP JSON-RPC). No new crates.What this does
stream(), so many Grok sessions and other backends can run in parallel_x.ai/interject(same turn; does not queue or cancel)session/cancel(kicks the in-flight turn; session stays, resume can reattach)--permission-mode auto, not--always-approve/compact→_x.ai/compact_conversation;/clearrefused (Grok has/new)What this does not
Verified against grok 1.0.30
--helpand live ACP method names.cargo test --lib: 216 passed. Livegrok agent stdiosmoke is still outstanding.