[vr4manta]

SPLAT-2866

Changes

• Changed operator to load cloud config from openshift-config-managed
• Added logic to add new VAP for validating infrastructure (FD) removals against current CPMS and machines
• Created E2Es for new vSphere VAP

Notes:
This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

• SPLAT-2745: Changed vSphere cloud config to be read from openshift-config-managed #1495
• SPLAT-2790: Added new VAP for vSphere infra validation against current cpms and machines #1510
• SPLAT-2813: Create VAP E2Es #1517
• SPLAT-2854: Fixing issue related to unintended VAP interactions #1518
• SPLAT-2858: Fixing test issue where error result was for other resource type #1522
• OCPBUGS-99903: Fixing test issue where error result was for other resource type #1524
• SPLAT-2826: Compare against oldObject in vSphere failure-domain VAPs #1536

Since release 4.21 did not have the original feature gate, this PR require changes to go.mod to pick up the new feature gate.

[openshift-ci]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2866 which is a valid jira issue.

Details

In response to this:

SPLAT-2866

Changes

• Changed operator to load cloud config from openshift-config-managed
• Added logic to add new VAP for validating infrastructure (FD) removals against current CPMS and machines
• Created E2Es for new vSphere VAP

Notes:
This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

• SPLAT-2745: Changed vSphere cloud config to be read from openshift-config-managed #1495
• SPLAT-2790: Added new VAP for vSphere infra validation against current cpms and machines #1510
• SPLAT-2813: Create VAP E2Es #1517
• SPLAT-2854: Fixing issue related to unintended VAP interactions #1518
• SPLAT-2858: Fixing test issue where error result was for other resource type #1522
• OCPBUGS-99903: Fixing test issue where error result was for other resource type #1524
• SPLAT-2826: Compare against oldObject in vSphere failure-domain VAPs #1536

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ea3710ad-6bca-429d-8846-39a018f0bf0e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[vr4manta]

/test all

[vr4manta]

/test all

[vr4manta]

/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upgrade
/test e2e-vsphere-ovn-techpreview
/test e2e-vsphere-ovn-techpreview-serial

[openshift-ci]

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-upgrade	95ba914	link	false	/test e2e-vsphere-ovn-upgrade
ci/prow/e2e-vsphere-ovn-techpreview-serial	95ba914	link	false	/test e2e-vsphere-ovn-techpreview-serial
ci/prow/e2e-vsphere-ovn	95ba914	link	false	/test e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-techpreview	95ba914	link	false	/test e2e-vsphere-ovn-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/installer#10874
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/installer#10874
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.21-e2e-vsphere-ovn-zones-techpreview-serial-1of2
• periodic-ci-openshift-release-main-nightly-4.21-e2e-vsphere-ovn-zones-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/925787e0-b8d9-11f1-86be-d925cabc7c50-0

[damdo]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-virtualmedia

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/installer#10874
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.21-e2e-vsphere-ovn-zones-techpreview-serial-1of2
• periodic-ci-openshift-release-main-nightly-4.21-e2e-vsphere-ovn-zones-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0cc21600-bc39-11f1-8407-b56d3ed53aea-0

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/installer#10874
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-vcf-migration-operator-main-4.21-e2e-vsphere-vcf-migration

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/37749120-bc39-11f1-8844-56129bcf18d6-0

[vr4manta]

Both of the ovn zones techpreview serial passed and saw the Day 2 tests ran and passed.
/verified by CI

[openshift-ci-robot]

@vr4manta: This PR has been marked as verified by CI.

Details

In response to this:

Both of the ovn zones techpreview serial passed and saw the Day 2 tests ran and passed.
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/label backport-risk-assessed

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/installer#10874
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-vcf-migration-operator-main-4.21-e2e-vsphere-vcf-migration

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e049fb00-bcc5-11f1-95e2-fb4ec01e30aa-0

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/installer#10874
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-multiarch-tuning-operator-v1.x-ocp422-e2e-aws-ovn-proxy-mto-origin

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/91307ba0-bccc-11f1-9b3a-b55ebbe351b6-0

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/installer#10874
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[JoelSpeed]

/label jira/valid-bug