Repository navigation
Generate Region Plots Directly - #2895
Merged
Merged
Conversation
Member
|
Nice PR. We might be able to plot everything thing soon 🚀 |
paulromano
enabled auto-merge (squash)
April 11, 2024 13:28
Member
|
Looks like that extra assert in the testing picked up an error in the latest CI run. |
shimwell
reviewed
Apr 11, 2024
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A continuation of #2648, these changes allow regions to be plotted directly without need for a cell definition. A simple region can now be plotted with the following:
There was a little more nuance here as the
color_by,color,legend, andlegend_kwargsarguments no longer have meaning at this level of geometry definition, so I've addressed those as best I could for now.Other
Also cleaned up the
openmc.Cell.plotdocstring a bit.Checklist
- [ ] I have run clang-format (version 15) on any C++ source files (if applicable)