Repository navigation
Adding source option to plot - #2863
Conversation
|
Added some tests that get the coordinates of the scatter plot and compare with source location for different basis and with different plane_tolerances |
|
Sorry to nudge, is anyone able to review this one. I'm keen to see if it gets accepted or not. |
|
Just keeping this branch upto date with develop. I'm making use of this branch for plotting stellerator sources and finding it quite useful. |
paulromano
left a comment
There was a problem hiding this comment.
Sorry it took so long to get this one resolved @shimwell @jon-proximafusion! I just made a few updates to your branch. Most importantly, the sample_external_source method in Model executes in a temporary directory so as not to mess with any local files. If you're happy with the changes, let me know and we can get this merged in!
|
oh wow, you have made my day @paulromano |
|
Thanks for the improvements, sorry it needed so many changes. I see the temporary dir and yes that is certainly a good idea to avoid overwriting local xml files. The changes look great. I shall enable auto merge so we don't have to come back. |
Co-authored-by: Jon Shimwell <jon@proximafusion.com> Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
Description
A while back there was a slack conversation where we talked about adding source plotting to the geometry plot.
@pshriwise recently put in a PR for adding source plotting to the openmc-plotter package.
So I made this PR that adds source plotting to the openmc python API for those users who might want the source term plotting on the geometry from the Python API.
Here are some examples of plots which have a source
tagging @Asureda for your interest
Checklist