Repository navigation
fix(deps): patch webpki, drop NATS websockets - #491
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security auditis red onmainand on every open PR. It is not the dependabot bump (#464): RustSec published four advisories on 19 and 20 October against crates already inCargo.lock, so any commit fails the audit now. Three clear with patch bumps. The fourth sits in a crate that cannot be bumped, so the feature that pulls it in is switched off and the leftover lockfile entry is registered as not in the graph, which the repo's own script verifies.Related issue
None. Same shape as #476 and #480.
Changes
rustls-webpki0.103.15 → 0.103.16,webpki-rootsandwebpki-root-certs1.0.9 → 1.0.10 (Cargo.lockonly), clearing RUSTSEC-2026-0382, -0381 and -0383.rustls-webpkiverifies every TLS connection the node makes throughreqwest,sqlxand the NATS client, so the first is reachable. The existing requirements already allowed the patches.async-natsis declared without itswebsocketsfeature (Cargo.toml: its default features minus that one).webpki-roots0.26.11 carries RUSTSEC-2026-0381 too and cannot move: onlytokio-websockets0.10 pulls it in,async-nats0.50 pins that, and 0.50.0 is the newest release. Nothing here configures aws://orwss://NATS URL, so the transport was dead weight. A WebSocket NATS URL is no longer supported by the client..cargo/audit.toml: RUSTSEC-2026-0381 registered asnot-in-graph. The crate stays inCargo.lockbecauseasync-natsnames it in a weak feature (tokio-websockets?/ring) and cargo records that edge whether or not the feature is on;cargo auditreads the lockfile. The entry is void ifwebsocketsis re-enabled, and it expires 2027-01-18.CHANGELOG.md: an entry under Unreleased → Fixed.Things to know
not-in-graphclaim is checked, not asserted.scripts/check-audit-register.shrunscargo tree -i webpki-roots@0.26.11 --target allagainst the default graph and the shipped image build (-p dpp-node --features s3). I also re-enabledwebsocketsin a scratch copy and confirmed the script then fails the entry in both graphs, so the green result can fail.owner: LKSNDRTMLKVon the new entry records the founder's sign-off, as on the other entries.mainafter this lands to pick up the patched lockfile; theirSecurity auditwill keep failing until then.Checklist
just lintpasses locally (part ofjust check)just fmtapplied (fmt-checkinjust check)just testpasses (unit): 1493 passed, 3 skippedjust test-integration— not run; nothing in persistence, lifecycle or auth changed, and CI runs the Docker tiersprintln!/eprintln!/dbg!in service-cratesrc/—just debug-check, injust check.envfiles in the diff (four files:Cargo.toml,Cargo.lock,.cargo/audit.toml,CHANGELOG.md)just checkends green locally, includingcargo audit --deny yanked --deny unmaintained,cargo denyandcheck-audit-register.sh(5 entries, all current)